Kaydet (Commit) 63d1f47b authored tarafından Martin Panter's avatar Martin Panter

Issue #26309: Rewrite test in main thread and avoid race condition

üst ba8474b7
...@@ -326,28 +326,29 @@ class SocketServerTest(unittest.TestCase): ...@@ -326,28 +326,29 @@ class SocketServerTest(unittest.TestCase):
SocketServer.TCPServer((HOST, -1), SocketServer.TCPServer((HOST, -1),
SocketServer.StreamRequestHandler) SocketServer.StreamRequestHandler)
class MiscTestCase(unittest.TestCase):
def test_shutdown_request_called_if_verify_request_false(self): def test_shutdown_request_called_if_verify_request_false(self):
# Issue #26309: BaseServer should call shutdown_request even if # Issue #26309: BaseServer should call shutdown_request even if
# verify_request is False # verify_request is False
result = {"shutdown_called": False}
class MyServer(SocketServer.TCPServer): class MyServer(SocketServer.TCPServer):
def verify_request(self, request, client_address): def verify_request(self, request, client_address):
return False return False
shutdown_called = 0
def shutdown_request(self, request): def shutdown_request(self, request):
result["shutdown_called"] = True self.shutdown_called += 1
SocketServer.TCPServer.shutdown_request(self, request) SocketServer.TCPServer.shutdown_request(self, request)
def connect_to_server(proto, addr): server = MyServer((HOST, 0), SocketServer.StreamRequestHandler)
s = socket.socket(proto, socket.SOCK_STREAM) s = socket.socket(server.address_family, socket.SOCK_STREAM)
s.connect(addr) s.connect(server.server_address)
s.close() s.close()
server.handle_request()
self.run_server(MyServer, self.assertEqual(server.shutdown_called, 1)
SocketServer.StreamRequestHandler, server.server_close()
connect_to_server)
self.assertEqual(result["shutdown_called"], True)
def test_main(): def test_main():
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment