Kaydet (Commit) 6a0b5c41 authored tarafından Senthil Kumaran's avatar Senthil Kumaran

Code Changes as per review comments by Antoine Pitrou.

üst 713d3039
...@@ -150,31 +150,18 @@ class XMLRPCTestCase(unittest.TestCase): ...@@ -150,31 +150,18 @@ class XMLRPCTestCase(unittest.TestCase):
[('Authorization', 'Basic dXNlcg==')], {})) [('Authorization', 'Basic dXNlcg==')], {}))
def test_ssl_presence(self): def test_ssl_presence(self):
#Check for ssl support
have_ssl = False
if hasattr(socket, 'ssl'):
have_ssl = True
else:
try:
import ssl
except:
pass
else:
have_ssl = True
try: try:
xmlrpc.client.ServerProxy('https://localhost:9999').bad_function() import ssl
except: except:
exc = sys.exc_info() have_ssl = False
if exc[0] == socket.error:
self.assertTrue(have_ssl,
"No SSL support, but xmlrpclib reports supported.")
elif exc[0] == NotImplementedError and str(exc[1]) == \
"your version of http.client doesn't support HTTPS":
self.assertFalse(have_ssl,
"SSL supported, but xmlrpclib reports not.")
else: else:
self.fail("Unable to determine status of SSL check.") has_ssl = True
try:
xmlrpc.client.ServerProxy('https://localhost:9999').bad_function()
except NotImplementedError:
self.assertFalse(has_ssl, "xmlrpc client's error with SSL support")
except socket.error:
self.assertTrue(has_ssl)
class HelperTestCase(unittest.TestCase): class HelperTestCase(unittest.TestCase):
def test_escape(self): def test_escape(self):
......
...@@ -1330,7 +1330,7 @@ class SafeTransport(Transport): ...@@ -1330,7 +1330,7 @@ class SafeTransport(Transport):
if self._connection and host == self._connection[0]: if self._connection and host == self._connection[0]:
return self._connection[1] return self._connection[1]
if not hasattr(http.client, "ssl"): if not hasattr(http.client, "HTTPSConnection"):
raise NotImplementedError( raise NotImplementedError(
"your version of http.client doesn't support HTTPS") "your version of http.client doesn't support HTTPS")
# create a HTTPS connection object from a host descriptor # create a HTTPS connection object from a host descriptor
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment