Kaydet (Commit) 709b4c35 authored tarafından R. David Murray's avatar R. David Murray

Merged revisions 78139 via svnmerge from

svn+ssh://pythondev@svn.python.org/python/branches/py3k

................
  r78139 | r.david.murray | 2010-02-10 19:15:05 -0500 (Wed, 10 Feb 2010) | 15 lines

  Merged revisions 78137 via svnmerge from
  svn+ssh://pythondev@svn.python.org/python/trunk

  ........
    r78137 | r.david.murray | 2010-02-10 17:42:04 -0500 (Wed, 10 Feb 2010) | 8 lines

    Issue 7835:  Shelve's __del__ method calls its close method, and its
    close method refers to an identifier in the global module namespace.
    This means that when __del__ is called during interpreter shutdown (if,
    for example, the calling program still has a pointer to the shelf),
    sometimes that global identifier would wind up being None, causing
    mysterious 'ignored' exceptions.  This patch checks for the possible None
    value first before using the global, thus avoiding the error messages.
  ........
................
üst 54319287
...@@ -136,7 +136,11 @@ class Shelf(collections.MutableMapping): ...@@ -136,7 +136,11 @@ class Shelf(collections.MutableMapping):
self.dict.close() self.dict.close()
except AttributeError: except AttributeError:
pass pass
self.dict = _ClosedDict() # _ClosedDict can be None when close is called from __del__ during shutdown
if _ClosedDict is None:
self.dict = None
else:
self.dict = _ClosedDict()
def __del__(self): def __del__(self):
if not hasattr(self, 'writeback'): if not hasattr(self, 'writeback'):
......
...@@ -79,6 +79,9 @@ Core and Builtins ...@@ -79,6 +79,9 @@ Core and Builtins
Library Library
------- -------
- Issue #7835: shelve should no longer produce mysterious warnings during
interpreter shutdown.
- Issue #6233: ElementTree failed converting unicode characters to XML - Issue #6233: ElementTree failed converting unicode characters to XML
entities when they could't be represented in the requested output entities when they could't be represented in the requested output
encoding. Patch by Jerry Chen. encoding. Patch by Jerry Chen.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment