Kaydet (Commit) 897bba75 authored tarafından Denis Osipov's avatar Denis Osipov Kaydeden (comit) Victor Stinner

bpo-30584: Fix test_os fails on non-English Windows (#1980)

* Fix bpo-30584

* Adding a comment mentionning the bpo and explaining what is the identifier

* Add Denis Osipov to Misc/ACKS
üst add98eb4
......@@ -472,7 +472,9 @@ class StatAttributeTests(unittest.TestCase):
# force CreateFile to fail with ERROR_ACCESS_DENIED.
DETACHED_PROCESS = 8
subprocess.check_call(
['icacls.exe', fname, '/deny', 'Users:(S)'],
# bpo-30584: Use security identifier *S-1-5-32-545 instead
# of localized "Users" to not depend on the locale.
['icacls.exe', fname, '/deny', '*S-1-5-32-545:(S)'],
creationflags=DETACHED_PROCESS
)
result = os.stat(fname)
......
......@@ -1132,6 +1132,7 @@ William Orr
Michele Orrù
Tomáš Orsava
Oleg Oshmyan
Denis Osipov
Denis S. Otkidach
Peter Otten
Michael Otteneder
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment