bpo-32215: Fix performance regression in sqlite3 (GH-8511)

8d1e190f · Berker Peksag · GitHub · ffef50f1 · 8d1e190f · 8d1e190f
Unverified Kaydet (Commit) 8d1e190f authored Eyl 20, 2018 tarafından Berker Peksag Kaydeden (comit) GitHub Eyl 20, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 4 deletions

2018-07-28-12-08-53.bpo-32215.EU68SY.rst ...S.d/next/Library/2018-07-28-12-08-53.bpo-32215.EU68SY.rst +2 -0

statement.c Modules/_sqlite/statement.c +4 -4

No files found.
--- a/Misc/NEWS.d/next/Library/2018-07-28-12-08-53.bpo-32215.EU68SY.rst
+++ b/Misc/NEWS.d/next/Library/2018-07-28-12-08-53.bpo-32215.EU68SY.rst
+Fix performance regression in :mod:`sqlite3` when a DML statement appeared
+in a different line than the rest of the SQL query.
--- a/Modules/_sqlite/statement.c
+++ b/Modules/_sqlite/statement.c
@@ -85,10 +85,10 @@ int pysqlite_statement_create(pysqlite_Statement* self, pysqlite_Connection* con
                continue;
        }
-        self->is_dml = (PyOS_strnicmp(p, "insert ", 7) == 0)
+        self->is_dml = (PyOS_strnicmp(p, "insert", 6) == 0)
-                    || (PyOS_strnicmp(p, "update ", 7) == 0)
+                    || (PyOS_strnicmp(p, "update", 6) == 0)
-                    || (PyOS_strnicmp(p, "delete ", 7) == 0)
+                    || (PyOS_strnicmp(p, "delete", 6) == 0)
-                    || (PyOS_strnicmp(p, "replace ", 8) == 0);
+                    || (PyOS_strnicmp(p, "replace", 7) == 0);
        break;
    }