Kaydet (Commit) 99773359 authored tarafından Tarek Ziadé's avatar Tarek Ziadé

#6954: Fixed crash when using DISTUTILS_DEBUG flag in Distutils.

üst ccaf380f
...@@ -359,7 +359,7 @@ Common commands: (see '--help-commands' for more) ...@@ -359,7 +359,7 @@ Common commands: (see '--help-commands' for more)
parser = ConfigParser() parser = ConfigParser()
for filename in filenames: for filename in filenames:
if DEBUG: if DEBUG:
self.announce(" reading", filename) self.announce(" reading %s" % filename)
parser.read(filename) parser.read(filename)
for section in parser.sections(): for section in parser.sections():
options = parser.options(section) options = parser.options(section)
......
...@@ -17,6 +17,9 @@ class Log: ...@@ -17,6 +17,9 @@ class Log:
self.threshold = threshold self.threshold = threshold
def _log(self, level, msg, args): def _log(self, level, msg, args):
if level not in (DEBUG, INFO, WARN, ERROR, FATAL):
raise ValueError('%s wrong log level' % str(level))
if level >= self.threshold: if level >= self.threshold:
if args: if args:
msg = msg % args msg = msg % args
......
...@@ -200,6 +200,13 @@ class DistributionTestCase(support.TempdirManager, ...@@ -200,6 +200,13 @@ class DistributionTestCase(support.TempdirManager,
self.assertEquals(cmds, ['distutils.command', 'one', 'two']) self.assertEquals(cmds, ['distutils.command', 'one', 'two'])
def test_announce(self):
# make sure the level is known
dist = Distribution()
args = ('ok',)
kwargs = {'level': 'ok2'}
self.assertRaises(ValueError, dist.announce, args, kwargs)
class MetadataTestCase(support.TempdirManager, support.EnvironGuard, class MetadataTestCase(support.TempdirManager, support.EnvironGuard,
unittest.TestCase): unittest.TestCase):
......
...@@ -379,6 +379,8 @@ Core and Builtins ...@@ -379,6 +379,8 @@ Core and Builtins
Library Library
------- -------
- Issue #6954: Fixed crash when using DISTUTILS_DEBUG flag in Distutils.
- Issue #6851: Fix urllib.urlopen crash on secondairy threads on OSX 10.6 - Issue #6851: Fix urllib.urlopen crash on secondairy threads on OSX 10.6
- Issue #4606: Passing 'None' if ctypes argtype is set to POINTER(...) - Issue #4606: Passing 'None' if ctypes argtype is set to POINTER(...)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment