bpo-29876: fix DECREF for NULL value in subelement() (GH-760)

9c0408d9 · Xiang Zhang · GitHub · e6a55dd8 · 9c0408d9
Kaydet (Commit) 9c0408d9 authored Mar 22, 2017 tarafından Xiang Zhang Kaydeden (comit) GitHub Mar 22, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

_elementtree.c Modules/_elementtree.c +2 -1

No files found.
--- a/Modules/_elementtree.c
+++ b/Modules/_elementtree.c
@@ -524,8 +524,9 @@ subelement(PyObject* self, PyObject* args, PyObject* kw)
    }

    elem = element_new(tag, attrib);
-
    Py_DECREF(attrib);
+    if (elem == NULL)
+        return NULL;

    if (element_add_subelement(parent, elem) < 0) {
        Py_DECREF(elem);