Fix leak involving BuildValue("...O...").

9c6ba5e9 · Guido van Rossum · ebee0256 · 9c6ba5e9
Kaydet (Commit) 9c6ba5e9 authored Ock 12, 1997 tarafından Guido van Rossum
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 3 deletions

binascii.c Modules/binascii.c +7 -3

No files found.
--- a/Modules/binascii.c
+++ b/Modules/binascii.c
@@ -492,9 +492,13 @@ binascii_a2b_hqx(self, args)
 		Py_DECREF(rv);
 		return NULL;
 	}
-	_PyString_Resize(&rv, (bin_data - (unsigned char *)PyString_AsString(rv)));
-	if ( rv )
-		return Py_BuildValue("Oi", rv, done);
+	_PyString_Resize(
+		&rv, (bin_data - (unsigned char *)PyString_AsString(rv)));
+	if (rv) {
+		PyObject *rrv = Py_BuildValue("Oi", rv, done);
+		Py_DECREF(rv);
+		return rrv;
+	}
 	return NULL;
 }