bpo-31234, socket.create_connection(): Fix ref cycle (#3546)

acb9fa79 · Victor Stinner · GitHub · b157ce1e · acb9fa79 · acb9fa79
Kaydet (Commit) acb9fa79 authored Eyl 13, 2017 tarafından Victor Stinner Kaydeden (comit) GitHub Eyl 13, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

socket.py Lib/socket.py +2 -0

2017-09-13-18-05-56.bpo-31234.lGkcPg.rst ...S.d/next/Library/2017-09-13-18-05-56.bpo-31234.lGkcPg.rst +2 -0

No files found.
--- a/Lib/socket.py
+++ b/Lib/socket.py
@@ -711,6 +711,8 @@ def create_connection(address, timeout=_GLOBAL_DEFAULT_TIMEOUT,
            if source_address:
                sock.bind(source_address)
            sock.connect(sa)
+            # Break explicitly a reference cycle
+            err = None
            return sock

        except error as _:

--- a/Misc/NEWS.d/next/Library/2017-09-13-18-05-56.bpo-31234.lGkcPg.rst
+++ b/Misc/NEWS.d/next/Library/2017-09-13-18-05-56.bpo-31234.lGkcPg.rst
+socket.create_connection() now fixes manually a reference cycle: clear the
+variable storing the last exception on success.