Kaydet (Commit) c3189696 authored tarafından Guido van Rossum's avatar Guido van Rossum

Rich comparisons fall-out:

- Renamed Py_TPFLAGS_NEWSTYLENUMBER to Py_TPFLAGS_CHECKTYPES.

- Use PyObject_RichCompareBool() in PySequence_Contains().
üst 8998b4f6
...@@ -6,7 +6,7 @@ ...@@ -6,7 +6,7 @@
#include "structmember.h" /* we need the offsetof() macro from there */ #include "structmember.h" /* we need the offsetof() macro from there */
#define NEW_STYLE_NUMBER(o) PyType_HasFeature((o)->ob_type, \ #define NEW_STYLE_NUMBER(o) PyType_HasFeature((o)->ob_type, \
Py_TPFLAGS_NEWSTYLENUMBER) Py_TPFLAGS_CHECKTYPES)
/* Shorthands to return certain errors */ /* Shorthands to return certain errors */
...@@ -1363,11 +1363,11 @@ PySequence_Contains(PyObject *w, PyObject *v) /* v in w */ ...@@ -1363,11 +1363,11 @@ PySequence_Contains(PyObject *w, PyObject *v) /* v in w */
} }
return -1; return -1;
} }
cmp = PyObject_Compare(v, x); cmp = PyObject_RichCompareBool(v, x, Py_EQ);
Py_XDECREF(x); Py_XDECREF(x);
if (cmp == 0) if (cmp > 0)
return 1; return 1;
if (PyErr_Occurred()) if (cmp < 0)
return -1; return -1;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment