Kaydet (Commit) d9c116ca authored tarafından Raymond Hettinger's avatar Raymond Hettinger

Add a spacing saving heuristic to deque's extend methods

üst bbf8ce5b
...@@ -543,8 +543,8 @@ class TestBasic(unittest.TestCase): ...@@ -543,8 +543,8 @@ class TestBasic(unittest.TestCase):
check = self.check_sizeof check = self.check_sizeof
check(deque(), basesize + blocksize) check(deque(), basesize + blocksize)
check(deque('a'), basesize + blocksize) check(deque('a'), basesize + blocksize)
check(deque('a' * (BLOCKLEN // 2)), basesize + blocksize) check(deque('a' * (BLOCKLEN - 1)), basesize + blocksize)
check(deque('a' * (BLOCKLEN // 2 + 1)), basesize + 2 * blocksize) check(deque('a' * BLOCKLEN), basesize + 2 * blocksize)
check(deque('a' * (42 * BLOCKLEN)), basesize + 43 * blocksize) check(deque('a' * (42 * BLOCKLEN)), basesize + 43 * blocksize)
class TestVariousIteratorArgs(unittest.TestCase): class TestVariousIteratorArgs(unittest.TestCase):
......
...@@ -332,6 +332,14 @@ deque_extend(dequeobject *deque, PyObject *iterable) ...@@ -332,6 +332,14 @@ deque_extend(dequeobject *deque, PyObject *iterable)
return result; return result;
} }
/* Space saving heuristic. Start filling from the left */
if (Py_SIZE(deque) == 0) {
assert(deque->leftblock == deque->rightblock);
assert(deque->leftindex == deque->rightindex+1);
deque->leftindex = 1;
deque->rightindex = 0;
}
it = PyObject_GetIter(iterable); it = PyObject_GetIter(iterable);
if (it == NULL) if (it == NULL)
return NULL; return NULL;
...@@ -385,6 +393,14 @@ deque_extendleft(dequeobject *deque, PyObject *iterable) ...@@ -385,6 +393,14 @@ deque_extendleft(dequeobject *deque, PyObject *iterable)
return result; return result;
} }
/* Space saving heuristic. Start filling from the right */
if (Py_SIZE(deque) == 0) {
assert(deque->leftblock == deque->rightblock);
assert(deque->leftindex == deque->rightindex+1);
deque->leftindex = BLOCKLEN - 1;
deque->rightindex = BLOCKLEN - 2;
}
it = PyObject_GetIter(iterable); it = PyObject_GetIter(iterable);
if (it == NULL) if (it == NULL)
return NULL; return NULL;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment