Kaydet (Commit) db80aec6 authored tarafından Steve Dower's avatar Steve Dower

Fix installer Back button going to wrong page when modifying.

Also fix error when doing test builds without documentation file.
üst 8b62bbf2
...@@ -325,7 +325,11 @@ class PythonBootstrapperApplication : public CBalBaseBootstrapperApplication { ...@@ -325,7 +325,11 @@ class PythonBootstrapperApplication : public CBalBaseBootstrapperApplication {
case ID_CUSTOM1_BACK_BUTTON: case ID_CUSTOM1_BACK_BUTTON:
SavePageSettings(); SavePageSettings();
GoToPage(PAGE_INSTALL); if (_modifying) {
GoToPage(PAGE_MODIFY);
} else {
GoToPage(PAGE_INSTALL);
}
break; break;
case ID_INSTALL_CUSTOM_BUTTON: __fallthrough; case ID_INSTALL_CUSTOM_BUTTON: __fallthrough;
...@@ -412,6 +416,7 @@ class PythonBootstrapperApplication : public CBalBaseBootstrapperApplication { ...@@ -412,6 +416,7 @@ class PythonBootstrapperApplication : public CBalBaseBootstrapperApplication {
_engine->SetVariableString(L"InstallAllUsersState", L"disable"); _engine->SetVariableString(L"InstallAllUsersState", L"disable");
_engine->SetVariableString(L"TargetDirState", L"disable"); _engine->SetVariableString(L"TargetDirState", L"disable");
_engine->SetVariableString(L"CustomBrowseButtonState", L"disable"); _engine->SetVariableString(L"CustomBrowseButtonState", L"disable");
_modifying = TRUE;
GoToPage(PAGE_CUSTOM1); GoToPage(PAGE_CUSTOM1);
break; break;
...@@ -2518,6 +2523,7 @@ public: ...@@ -2518,6 +2523,7 @@ public:
_suppressDowngradeFailure = FALSE; _suppressDowngradeFailure = FALSE;
_suppressRepair = FALSE; _suppressRepair = FALSE;
_modifying = FALSE;
_overridableVariables = nullptr; _overridableVariables = nullptr;
_taskbarList = nullptr; _taskbarList = nullptr;
...@@ -2598,6 +2604,7 @@ private: ...@@ -2598,6 +2604,7 @@ private:
BOOL _suppressDowngradeFailure; BOOL _suppressDowngradeFailure;
BOOL _suppressRepair; BOOL _suppressRepair;
BOOL _modifying;
STRINGDICT_HANDLE _overridableVariables; STRINGDICT_HANDLE _overridableVariables;
......
...@@ -10,6 +10,7 @@ ...@@ -10,6 +10,7 @@
<Feature Id="DefaultFeature" AllowAdvertise="no" Title="!(loc.Title)" Description="!(loc.Description)"> <Feature Id="DefaultFeature" AllowAdvertise="no" Title="!(loc.Title)" Description="!(loc.Description)">
<ComponentGroupRef Id="doc" /> <ComponentGroupRef Id="doc" />
<?ifdef DocFilename ?>
<Component Id="doc_shortcut" Directory="MenuDir" Guid="*"> <Component Id="doc_shortcut" Directory="MenuDir" Guid="*">
<RegistryKey Root="HKMU" Key="[REGISTRYKEY]"> <RegistryKey Root="HKMU" Key="[REGISTRYKEY]">
<RegistryValue Key="Help\Main Python Documentation" Type="string" Value="[#python.chm]" KeyPath="yes" /> <RegistryValue Key="Help\Main Python Documentation" Type="string" Value="[#python.chm]" KeyPath="yes" />
...@@ -20,6 +21,7 @@ ...@@ -20,6 +21,7 @@
Description="!(loc.ShortcutDescription)" /> Description="!(loc.ShortcutDescription)" />
<RemoveFolder Id="Remove_MenuDir" On="uninstall" /> <RemoveFolder Id="Remove_MenuDir" On="uninstall" />
</Component> </Component>
<?endif ?>
</Feature> </Feature>
</Product> </Product>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment