Kaydet (Commit) de046446 authored tarafından Ned Deily's avatar Ned Deily Kaydeden (comit) GitHub

bpo-28087: Skip test_asyncore and test_eintr poll failures on macOS. (#462)

* bpo-28087: Skip test_asyncore and test_eintr poll failures on macOS

Skip some tests of select.poll when running on macOS due to unresolved
issues with the underlying system poll function on some macOS versions.
üst cfcd7677
...@@ -437,6 +437,8 @@ class SelectEINTRTest(EINTRBaseTest): ...@@ -437,6 +437,8 @@ class SelectEINTRTest(EINTRBaseTest):
self.stop_alarm() self.stop_alarm()
self.assertGreaterEqual(dt, self.sleep_time) self.assertGreaterEqual(dt, self.sleep_time)
@unittest.skipIf(sys.platform == "darwin",
"poll may fail on macOS; see issue #28087")
@unittest.skipUnless(hasattr(select, 'poll'), 'need select.poll') @unittest.skipUnless(hasattr(select, 'poll'), 'need select.poll')
def test_poll(self): def test_poll(self):
poller = select.poll() poller = select.poll()
......
...@@ -661,6 +661,9 @@ class BaseTestAPI: ...@@ -661,6 +661,9 @@ class BaseTestAPI:
if HAS_UNIX_SOCKETS and self.family == socket.AF_UNIX: if HAS_UNIX_SOCKETS and self.family == socket.AF_UNIX:
self.skipTest("Not applicable to AF_UNIX sockets.") self.skipTest("Not applicable to AF_UNIX sockets.")
if sys.platform == "darwin" and self.use_poll:
self.skipTest("poll may fail on macOS; see issue #28087")
class TestClient(BaseClient): class TestClient(BaseClient):
def handle_expt(self): def handle_expt(self):
self.socket.recv(1024, socket.MSG_OOB) self.socket.recv(1024, socket.MSG_OOB)
......
...@@ -895,6 +895,10 @@ Tools/Demos ...@@ -895,6 +895,10 @@ Tools/Demos
Tests Tests
----- -----
- bpo-28087: Skip test_asyncore and test_eintr poll failures on macOS.
Skip some tests of select.poll when running on macOS due to unresolved
issues with the underlying system poll function on some macOS versions.
- Issue #29571: to match the behaviour of the ``re.LOCALE`` flag, - Issue #29571: to match the behaviour of the ``re.LOCALE`` flag,
test_re.test_locale_flag now uses ``locale.getpreferredencoding(False)`` to test_re.test_locale_flag now uses ``locale.getpreferredencoding(False)`` to
determine the candidate encoding for the test regex (allowing it to correctly determine the candidate encoding for the test regex (allowing it to correctly
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment