Kaydet (Commit) eac40fdf authored tarafından Martin Panter's avatar Martin Panter

Issue #19884: Avoid spurious output on OS X with Gnu Readline

Also adjust the test condition, because enable-meta-key was only added in
6.1, not 6.0.
üst dc60c75a
...@@ -44,7 +44,7 @@ class TestHistoryManipulation (unittest.TestCase): ...@@ -44,7 +44,7 @@ class TestHistoryManipulation (unittest.TestCase):
class TestReadline(unittest.TestCase): class TestReadline(unittest.TestCase):
@unittest.skipIf(readline._READLINE_VERSION < 0x0600 @unittest.skipIf(readline._READLINE_VERSION < 0x0601
and "libedit" not in readline.__doc__, and "libedit" not in readline.__doc__,
"not supported in this library version") "not supported in this library version")
def test_init(self): def test_init(self):
......
...@@ -33,6 +33,8 @@ Core and Builtins ...@@ -33,6 +33,8 @@ Core and Builtins
Library Library
------- -------
- Issue #19884: Avoid spurious output on OS X with Gnu Readline.
- Issue #10513: Fix a regression in Connection.commit(). Statements should - Issue #10513: Fix a regression in Connection.commit(). Statements should
not be reset after a commit. not be reset after a commit.
......
...@@ -961,19 +961,22 @@ setup_readline(void) ...@@ -961,19 +961,22 @@ setup_readline(void)
begidx = PyInt_FromLong(0L); begidx = PyInt_FromLong(0L);
endidx = PyInt_FromLong(0L); endidx = PyInt_FromLong(0L);
#ifndef __APPLE__ #ifdef __APPLE__
if (!isatty(STDOUT_FILENO)) { if (!using_libedit_emulation)
/* Issue #19884: stdout is not a terminal. Disable meta modifier
keys to not write the ANSI sequence "\033[1034h" into stdout. On
terminals supporting 8 bit characters like TERM=xterm-256color
(which is now the default Fedora since Fedora 18), the meta key is
used to enable support of 8 bit characters (ANSI sequence
"\033[1034h").
With libedit, this call makes readline() crash. */
rl_variable_bind ("enable-meta-key", "off");
}
#endif #endif
{
if (!isatty(STDOUT_FILENO)) {
/* Issue #19884: stdout is not a terminal. Disable meta modifier
keys to not write the ANSI sequence "\033[1034h" into stdout. On
terminals supporting 8 bit characters like TERM=xterm-256color
(which is now the default Fedora since Fedora 18), the meta key is
used to enable support of 8 bit characters (ANSI sequence
"\033[1034h").
With libedit, this call makes readline() crash. */
rl_variable_bind ("enable-meta-key", "off");
}
}
/* Initialize (allows .inputrc to override) /* Initialize (allows .inputrc to override)
* *
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment