Kaydet (Commit) ed3dd1c0 authored tarafından Senthil Kumaran's avatar Senthil Kumaran Kaydeden (comit) GitHub

Remove catching OSError in ftphandler test. Only URLError is raised in…

Remove catching OSError in ftphandler test. Only URLError is raised in urllib.request module. (#918)
üst 33db068d
......@@ -830,7 +830,6 @@ class HandlerTests(unittest.TestCase):
for url, ftp in [
("file://ftp.example.com//foo.txt", False),
("file://ftp.example.com///foo.txt", False),
# XXXX bug: fails with OSError, should be URLError
("file://ftp.example.com/foo.txt", False),
("file://somehost//foo/something.txt", False),
("file://localhost//foo/something.txt", False),
......@@ -839,7 +838,7 @@ class HandlerTests(unittest.TestCase):
try:
h.file_open(req)
# XXXX remove OSError when bug fixed
except (urllib.error.URLError, OSError):
except urllib.error.URLError:
self.assertFalse(ftp)
else:
self.assertIs(o.req, req)
......@@ -1689,7 +1688,6 @@ class HandlerTests(unittest.TestCase):
self.assertTrue(conn.fakesock.closed, "Connection not closed")
class MiscTests(unittest.TestCase):
def opener_has_handler(self, opener, handler_class):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment