Kaydet (Commit) ef9683b7 authored tarafından Eli Bendersky's avatar Eli Bendersky

Issue #17989: element_setattro returned incorrect error value.

This caused an exception to be raised later than expected.
üst 587d3bf7
...@@ -1808,17 +1808,16 @@ element_getattro(ElementObject* self, PyObject* nameobj) ...@@ -1808,17 +1808,16 @@ element_getattro(ElementObject* self, PyObject* nameobj)
return res; return res;
} }
static PyObject* static int
element_setattro(ElementObject* self, PyObject* nameobj, PyObject* value) element_setattro(ElementObject* self, PyObject* nameobj, PyObject* value)
{ {
char *name = ""; char *name = "";
if (PyUnicode_Check(nameobj)) if (PyUnicode_Check(nameobj))
name = _PyUnicode_AsString(nameobj); name = _PyUnicode_AsString(nameobj);
if (name == NULL) if (name == NULL) {
return NULL; return -1;
} else if (strcmp(name, "tag") == 0) {
if (strcmp(name, "tag") == 0) {
Py_DECREF(self->tag); Py_DECREF(self->tag);
self->tag = value; self->tag = value;
Py_INCREF(self->tag); Py_INCREF(self->tag);
...@@ -1837,11 +1836,12 @@ element_setattro(ElementObject* self, PyObject* nameobj, PyObject* value) ...@@ -1837,11 +1836,12 @@ element_setattro(ElementObject* self, PyObject* nameobj, PyObject* value)
self->extra->attrib = value; self->extra->attrib = value;
Py_INCREF(self->extra->attrib); Py_INCREF(self->extra->attrib);
} else { } else {
PyErr_SetString(PyExc_AttributeError, name); PyErr_SetString(PyExc_AttributeError,
return NULL; "Can't set arbitraty attributes on Element");
return -1;
} }
return NULL; return 0;
} }
static PySequenceMethods element_as_sequence = { static PySequenceMethods element_as_sequence = {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment