through the shell. also document the correct subprocess replacement for this
case
patch from Jean-Paul Calderone and Jani Hakala

PIPE_BUF is not defined on Windows, and probably has no meaning there.

Anyway the subprocess module uses another way to perform non-blocking reads (with a thread)

it does not fail when file descriptors are large.  Fixes issue3392.

Patch largely contributed by Frank Chu (fpmc) with some improvements by me.
See http://bugs.python.org/issue3392.

Candidate for backporting to release26-maint as it is a bug fix and changes no
public API.

(On windows, you still have to change one line to use pywin32
instead of the _subprocess helper module)

process on success or raise an exception on error.

commenting out True/False compatbility stuff, remove a use of apply(), and
remove a use of buffer() (just pulled the solution used in 3.0 which is direct
slicing).

  argument in python 2.5, this broke code that subclassed Popen to include its
  own poll method.  Fixed my moving _deadstate to an _internal_poll method.

  interrupted by a signal.

the last reference to the Popen instance was dropped.  Adding explicit
close() calls fixes it.

Candidate for backport to release25-maint.

The bits and pieces for the Windows side were already in place. The POSIX side is trivial (as usual) and uses os.kill().

subprocess.list2cmdline (windows).

try:
  ...
except:
  ...
  raise
else:
  ...

the else: is unecessary due to the blind except: with a raise.

kicked in during the critical section.  solution: disable gc during
that section.  Patch contributed by jpa and updated by me to cover the
race condition still existing what therve from twistedmatrix pointed
out (already seen and fixed in twisted's own subprocess code).

for inside of the final if needquotes: within subprocess.list2cmdline().

ignoring errors, and use this in subprocess to speed up
subprocess creation in close_fds mode. Patch by Mike Klaas.

not cleared before __del__ is run.

Applied patch 1124861.3.patch to solve bug #1124861: Automatically create pipes on Windows, if GetStdHandle fails. Will backport.

We had several if statements checking the value of a fd. This is unsafe, since valid fds might be zero. We should check for not None instead.

Re-implemented fix for #1531862 once again, in a way that works with Python 2.2. Fixes bug #1603424.

subprocess.

offending buildbot