1. 04 Mar, 2019 1 kayıt (commit)
  2. 02 Mar, 2019 1 kayıt (commit)
  3. 01 Mar, 2019 1 kayıt (commit)
    • Pablo Galindo's avatar
      bpo-35808: Retire pgen and use pgen2 to generate the parser (GH-11814) · 1f24a719
      Pablo Galindo yazdı
      Pgen is the oldest piece of technology in the CPython repository, building it requires various #if[n]def PGEN hacks in other parts of the code and it also depends more and more on CPython internals. This commit removes the old pgen C code and replaces it for a new version implemented in pure Python. This is a modified and adapted version of lib2to3/pgen2 that can generate grammar files compatibles with the current parser.
      
      This commit also eliminates all the #ifdef and code branches related to pgen, simplifying the code and making it more maintainable. The regen-grammar step now uses $(PYTHON_FOR_REGEN) that can be any version of the interpreter, so the new pgen code maintains compatibility with older versions of the interpreter (this also allows regenerating the grammar with the current CI solution that uses Python3.5). The new pgen Python module also makes use of the Grammar/Tokens file that holds the token specification, so is always kept in sync and avoids having to maintain duplicate token definitions.
      1f24a719
  4. 13 Şub, 2019 1 kayıt (commit)
  5. 01 Şub, 2019 2 kayıt (commit)
  6. 31 Ock, 2019 1 kayıt (commit)
  7. 24 Ock, 2019 1 kayıt (commit)
    • Emily Morehouse's avatar
      bpo-35224: PEP 572 Implementation (#10497) · 8f59ee01
      Emily Morehouse yazdı
      * Add tokenization of :=
      - Add token to Include/token.h. Add token to documentation in Doc/library/token.rst.
      - Run `./python Lib/token.py` to regenerate Lib/token.py.
      - Update Parser/tokenizer.c: add case to handle `:=`.
      
      * Add initial usage of := in grammar.
      
      * Update Python.asdl to match the grammar updates. Regenerated Include/Python-ast.h and Python/Python-ast.c
      
      * Update AST and compiler files in Python/ast.c and Python/compile.c. Basic functionality, this isn't scoped properly
      
      * Regenerate Lib/symbol.py using `./python Lib/symbol.py`
      
      * Tests - Fix failing tests in test_parser.py due to changes in token numbers for internal representation
      
      * Tests - Add simple test for := token
      
      * Tests - Add simple tests for named expressions using expr and suite
      
      * Tests - Update number of levels for nested expressions to prevent stack overflow
      
      * Update symbol table to handle NamedExpr
      
      * Update Grammar to allow assignment expressions in if statements.
      Regenerate Python/graminit.c accordingly using `make regen-grammar`
      
      * Tests - Add additional tests for named expressions in RoundtripLegalSyntaxTestCase, based on examples and information directly from PEP 572
      
      Note: failing tests are currently commented out (4 out of 24 tests currently fail)
      
      * Tests - Add temporary syntax test failure tests in test_parser.py
      
      Note: There is an outstanding TODO for this -- syntax tests need to be
      moved to a different file (presumably test_syntax.py), but this is
      covering what needs to be tested at the moment, and it's more convenient
      to run a single test for the time being
      
      * Add support for allowing assignment expressions as function argument annotations. Uncomment tests for these cases because they all pass now!
      
      * Tests - Move existing syntax tests out of test_parser.py and into test_named_expressions.py. Refactor syntax tests to use unittest
      
      * Add TargetScopeError exception to extend SyntaxError
      
      Note: This simply creates the TargetScopeError exception, it is not yet
      used anywhere
      
      * Tests - Update tests per PEP 572
      
      Continue refactoring test suite:
      The named expression test suite now checks for any invalid cases that
      throw exceptions (no longer limited to SyntaxErrors), assignment tests
      to ensure that variables are properly assigned, and scope tests to
      ensure that variable availability and values are correct
      
      Note:
      - There are still tests that are marked to skip, as they are not yet
      implemented
      - There are approximately 300 lines of the PEP that have not yet been
      addressed, though these may be deferred
      
      * Documentation - Small updates to XXX/todo comments
      
      - Remove XXX from child description in ast.c
      - Add comment with number of previously supported nested expressions for
      3.7.X in test_parser.py
      
      * Fix assert in seq_for_testlist()
      
      * Cleanup - Denote "Not implemented -- No keyword args" on failing test case. Fix PEP8 error for blank lines at beginning of test classes in test_parser.py
      
      * Tests - Wrap all file opens in `with...as` to ensure files are closed
      
      * WIP: handle f(a := 1)
      
      * Tests and Cleanup - No longer skips keyword arg test. Keyword arg test now uses a simpler test case and does not rely on an external file. Remove print statements from ast.c
      
      * Tests - Refactor last remaining test case that relied on on external file to use a simpler test case without the dependency
      
      * Tests - Add better description of remaning skipped tests. Add test checking scope when using assignment expression in a function argument
      
      * Tests - Add test for nested comprehension, testing value and scope. Fix variable name in skipped comprehension scope test
      
      * Handle restriction of LHS for named expressions - can only assign to LHS of type NAME. Specifically, restrict assignment to tuples
      
      This adds an alternative set_context specifically for named expressions,
      set_namedexpr_context. Thus, context is now set differently for standard
      assignment versus assignment for named expressions in order to handle
      restrictions.
      
      * Tests - Update negative test case for assigning to lambda to match new error message. Add negative test case for assigning to tuple
      
      * Tests - Reorder test cases to group invalid syntax cases and named assignment target errors
      
      * Tests - Update test case for named expression in function argument - check that result and variable are set correctly
      
      * Todo - Add todo for TargetScopeError based on Guido's comment (https://github.com/python/cpython/commit/2b3acd37bdfc2d35e5094228c6684050d2aa8b0a#r30472562)
      
      * Tests - Add named expression tests for assignment operator in function arguments
      
      Note: One of two tests are skipped, as function arguments are currently treating
      an assignment expression inside of parenthesis as one child, which does
      not properly catch the named expression, nor does it count arguments
      properly
      
      * Add NamedStore to expr_context. Regenerate related code with `make regen-ast`
      
      * Add usage of NamedStore to ast_for_named_expr in ast.c. Update occurances of checking for Store to also handle NamedStore where appropriate
      
      * Add ste_comprehension to _symtable_entry to track if the namespace is a comprehension. Initialize ste_comprehension to 0. Set set_comprehension to 1 in symtable_handle_comprehension
      
      * s/symtable_add_def/symtable_add_def_helper. Add symtable_add_def to handle grabbing st->st_cur and passing it to symtable_add_def_helper. This now allows us to call the original code from symtable_add_def by instead calling symtable_add_def_helper with a different ste.
      
      * Refactor symtable_record_directive to take lineno and col_offset as arguments instead of stmt_ty. This allows symtable_record_directive to be used for stmt_ty and expr_ty
      
      * Handle elevating scope for named expressions in comprehensions.
      
      * Handle error for usage of named expression inside a class block
      
      * Tests - No longer skip scope tests. Add additional scope tests
      
      * Cleanup - Update error message for named expression within a comprehension within a class. Update comments. Add assert for symtable_extend_namedexpr_scope to validate that we always find at least a ModuleScope if we don't find a Class or FunctionScope
      
      * Cleanup - Add missing case for NamedStore in expr_context_name. Remove unused var in set_namedexpr_content
      
      * Refactor - Consolidate set_context and set_namedexpr_context to reduce duplicated code. Special cases for named expressions are handled by checking if ctx is NamedStore
      
      * Cleanup - Add additional use cases for ast_for_namedexpr in usage comment. Fix multiple blank lines in test_named_expressions
      
      * Tests - Remove unnecessary test case. Renumber test case function names
      
      * Remove TargetScopeError for now. Will add back if needed
      
      * Cleanup - Small comment nit for consistency
      
      * Handle positional argument check with named expression
      
      * Add TargetScopeError exception definition. Add documentation for TargetScopeError in c-api docs. Throw TargetScopeError instead of SyntaxError when using a named expression in a comprehension within a class scope
      
      * Increase stack size for parser by 200. This is a minimal change (approx. 5kb) and should not have an impact on any systems. Update parser test to allow 99 nested levels again
      
      * Add TargetScopeError to exception_hierarchy.txt for test_baseexception.py_
      
      * Tests - Major update for named expression tests, both in test_named_expressions and test_parser
      
      - Add test for TargetScopeError
      - Add tests for named expressions in comprehension scope and edge cases
      - Add tests for named expressions in function arguments (declarations
      and call sites)
      - Reorganize tests to group them more logically
      
      * Cleanup - Remove unnecessary comment
      
      * Cleanup - Comment nitpicks
      
      * Explicitly disallow assignment expressions to a name inside parentheses, e.g.: ((x) := 0)
      
      - Add check for LHS types to detect a parenthesis then a name (see note)
      - Add test for this scenario
      - Update tests for changed error message for named assignment to a tuple
      (also, see note)
      
      Note: This caused issues with the previous error handling for named assignment
      to a LHS that contained an expression, such as a tuple. Thus, the check
      for the LHS of a named expression must be changed to be more specific if
      we wish to maintain the previous error messages
      
      * Cleanup - Wrap lines more strictly in test file
      
      * Revert "Explicitly disallow assignment expressions to a name inside parentheses, e.g.: ((x) := 0)"
      
      This reverts commit f1531400ca7d7a2d148830c8ac703f041740896d.
      
      * Add NEWS.d entry
      
      * Tests - Fix error in test_pickle.test_exceptions by adding TargetScopeError to list of exceptions
      
      * Tests - Update error message tests to reflect improved messaging convention (s/can't/cannot)
      
      * Remove cases that cannot be reached in compile.c. Small linting update.
      
      * Update Grammar/Tokens to add COLONEQUAL. Regenerate all files
      
      * Update TargetScopeError PRE_INIT and POST_INIT, as this was purposefully left out when fixing rebase conflicts
      
      * Add NamedStore back and regenerate files
      
      * Pass along line number and end col info for named expression
      
      * Simplify News entry
      
      * Fix compiler warning and explicity mark fallthrough
      8f59ee01
  8. 22 Ock, 2019 1 kayıt (commit)
    • Ivan Levkivskyi's avatar
      bpo-33416: Add end positions to Python AST (GH-11605) · 9932a228
      Ivan Levkivskyi yazdı
      The majority of this PR is tediously passing `end_lineno` and `end_col_offset` everywhere. Here are non-trivial points:
      * It is not possible to reconstruct end positions in AST "on the fly", some information is lost after an AST node is constructed, so we need two more attributes for every AST node `end_lineno` and `end_col_offset`.
      * I add end position information to both CST and AST.  Although it may be technically possible to avoid adding end positions to CST, the code becomes more cumbersome and less efficient.
      * Since the end position is not known for non-leaf CST nodes while the next token is added, this requires a bit of extra care (see `_PyNode_FinalizeEndPos`). Unless I made some mistake, the algorithm should be linear.
      * For statements, I "trim" the end position of suites to not include the terminal newlines and dedent (this seems to be what people would expect), for example in
        ```python
        class C:
            pass
      
        pass
        ```
        the end line and end column for the class definition is (2, 8).
      * For `end_col_offset` I use the common Python convention for indexing, for example for `pass` the `end_col_offset` is 4 (not 3), so that `[0:4]` gives one the source code that corresponds to the node.
      * I added a helper function `ast.get_source_segment()`, to get source text segment corresponding to a given AST node. It is also useful for testing.
      
      An (inevitable) downside of this PR is that AST now takes almost 25% more memory. I think however it is probably justified by the benefits.
      9932a228
  9. 13 Ock, 2019 1 kayıt (commit)
  10. 22 Ara, 2018 1 kayıt (commit)
    • Serhiy Storchaka's avatar
      bpo-30455: Generate all token related code and docs from Grammar/Tokens. (GH-10370) · 8ac65811
      Serhiy Storchaka yazdı
      "Include/token.h", "Lib/token.py" (containing now some data moved from
      "Lib/tokenize.py") and new files "Parser/token.c" (containing the code
      moved from "Parser/tokenizer.c") and "Doc/library/token-list.inc" (included
      in "Doc/library/token.rst") are now generated from "Grammar/Tokens" by
      "Tools/scripts/generate_token.py". The script overwrites files only if
      needed and can be used on the read-only sources tree.
      
      "Lib/symbol.py" is now generated by "Tools/scripts/generate_symbol_py.py"
      instead of been executable itself.
      
      Added new make targets "regen-token" and "regen-symbol" which are now
      dependencies of "regen-all".
      
      The documentation contains now strings for operators and punctuation tokens.
      8ac65811
  11. 17 Ara, 2018 1 kayıt (commit)
  12. 07 Ara, 2018 1 kayıt (commit)
  13. 22 Kas, 2018 1 kayıt (commit)
  14. 12 Kas, 2018 1 kayıt (commit)
    • Victor Stinner's avatar
      bpo-35081: Rename internal headers (GH-10275) · 621cebe8
      Victor Stinner yazdı
      Rename Include/internal/ headers:
      
      * pycore_hash.h -> pycore_pyhash.h
      * pycore_lifecycle.h -> pycore_pylifecycle.h
      * pycore_mem.h -> pycore_pymem.h
      * pycore_state.h -> pycore_pystate.h
      
      Add missing headers to Makefile.pre.in and PCbuild:
      
      * pycore_condvar.h.
      * pycore_hamt.h
      * pycore_pyhash.h
      621cebe8
  15. 11 Kas, 2018 1 kayıt (commit)
    • Victor Stinner's avatar
      bpo-35177: Add dependencies between header files (GH-10361) · 5f2df88b
      Victor Stinner yazdı
      * ast.h now includes Python-ast.h and node.h
      * parsetok.h now includes node.h and grammar.h
      * symtable.h now includes Python-ast.h
      * Modify asdl_c.py to enhance Python-ast.h:
      
        * Add #ifndef/#define Py_PYTHON_AST_H to be able to include the header
          twice
        * Add "extern { ... }" for C++
        * Undefine "Yield" macro conflicting with winbase.h
      
      * Remove "#undef Yield" from C files, it's now done in Python-ast.h
      * Remove now useless includes in C files
      5f2df88b
  16. 01 Kas, 2018 1 kayıt (commit)
    • Victor Stinner's avatar
      bpo-35081: Add _PyThreadState_GET() internal macro (GH-10266) · 50b48572
      Victor Stinner yazdı
      If Py_BUILD_CORE is defined, the PyThreadState_GET() macro access
      _PyRuntime which comes from the internal pycore_state.h header.
      Public headers must not require internal headers.
      
      Move PyThreadState_GET() and _PyInterpreterState_GET_UNSAFE() from
      Include/pystate.h to Include/internal/pycore_state.h, and rename
      PyThreadState_GET() to _PyThreadState_GET() there.
      
      The PyThreadState_GET() macro of pystate.h is now redefined when
      pycore_state.h is included, to use the fast _PyThreadState_GET().
      
      Changes:
      
      * Add _PyThreadState_GET() macro
      * Replace "PyThreadState_GET()->interp" with
        _PyInterpreterState_GET_UNSAFE()
      * Replace PyThreadState_GET() with _PyThreadState_GET() in internal C
        files (compiled with Py_BUILD_CORE defined), but keep
        PyThreadState_GET() in the public header files.
      * _testcapimodule.c: replace PyThreadState_GET() with
        PyThreadState_Get(); the module is not compiled with Py_BUILD_CORE
        defined.
      * pycore_state.h now requires Py_BUILD_CORE to be defined.
      50b48572
  17. 31 Eki, 2018 1 kayıt (commit)
    • Victor Stinner's avatar
      bpo-35081: Add pycore_ prefix to internal header files (GH-10263) · 27e2d1f2
      Victor Stinner yazdı
      * Rename Include/internal/ header files:
      
        * pyatomic.h -> pycore_atomic.h
        * ceval.h -> pycore_ceval.h
        * condvar.h -> pycore_condvar.h
        * context.h -> pycore_context.h
        * pygetopt.h -> pycore_getopt.h
        * gil.h -> pycore_gil.h
        * hamt.h -> pycore_hamt.h
        * hash.h -> pycore_hash.h
        * mem.h -> pycore_mem.h
        * pystate.h -> pycore_state.h
        * warnings.h -> pycore_warnings.h
      
      * PCbuild project, Makefile.pre.in, Modules/Setup: add the
        Include/internal/ directory to the search paths of header files.
      * Update includes. For example, replace #include "internal/mem.h"
        with #include "pycore_mem.h".
      27e2d1f2
  18. 27 Eyl, 2018 1 kayıt (commit)
  19. 24 Eyl, 2018 1 kayıt (commit)
  20. 12 Eyl, 2018 1 kayıt (commit)
  21. 10 Eyl, 2018 1 kayıt (commit)
  22. 21 Agu, 2018 1 kayıt (commit)
  23. 15 Agu, 2018 1 kayıt (commit)
  24. 24 Tem, 2018 1 kayıt (commit)
    • Victor Stinner's avatar
      bpo-34170: Add _PyCoreConfig.bytes_warning (GH-8447) · 53b7d4e4
      Victor Stinner yazdı
      Add more fields to _PyCoreConfig:
      
      * _check_hash_pycs_mode
      * bytes_warning
      * debug
      * inspect
      * interactive
      * legacy_windows_fs_encoding
      * legacy_windows_stdio
      * optimization_level
      * quiet
      * unbuffered_stdio
      * user_site_directory
      * verbose
      * write_bytecode
      
      Changes:
      
      * Remove pymain_get_global_config() and pymain_set_global_config()
        which became useless. These functions have been replaced by
        _PyCoreConfig_GetGlobalConfig() and
        _PyCoreConfig_SetGlobalConfig().
      * sys.flags.dont_write_bytecode value is now restricted to 1 even if
        -B option is specified multiple times on the command line.
      * PyThreadState_Clear() now uses the config from the current
        interpreter rather than using global Py_VerboseFlag
      53b7d4e4
  25. 23 Tem, 2018 1 kayıt (commit)
  26. 21 Tem, 2018 1 kayıt (commit)
  27. 19 Tem, 2018 1 kayıt (commit)
  28. 09 Tem, 2018 1 kayıt (commit)
  29. 28 Haz, 2018 1 kayıt (commit)
  30. 31 May, 2018 1 kayıt (commit)
  31. 29 May, 2018 1 kayıt (commit)
  32. 25 Ock, 2018 1 kayıt (commit)
  33. 31 Ara, 2017 1 kayıt (commit)
  34. 28 Kas, 2017 1 kayıt (commit)
  35. 24 Kas, 2017 1 kayıt (commit)
    • Victor Stinner's avatar
      bpo-32096: Remove obj and mem from _PyRuntime (#4532) · 9e87e777
      Victor Stinner yazdı
      bpo-32096, bpo-30860:  Partially revert the commit
      2ebc5ce4:
      
      * Move structures back from Include/internal/mem.h to
        Objects/obmalloc.c
      * Remove _PyObject_Initialize() and _PyMem_Initialize()
      * Remove Include/internal/pymalloc.h
      * Add test_capi.test_pre_initialization_api():
         Make sure that it's possible to call Py_DecodeLocale(), and then call
         Py_SetProgramName() with the decoded string, before Py_Initialize().
      
      PyMem_RawMalloc() and Py_DecodeLocale() can be called again before
      _PyRuntimeState_Init().
      Co-Authored-By: 's avatarEric Snow <ericsnowcurrently@gmail.com>
      9e87e777
  36. 17 Kas, 2017 1 kayıt (commit)
    • Victor Stinner's avatar
      tokenizer: Remove unused tabs options (#4422) · f2ddc6ac
      Victor Stinner yazdı
      Remove the following fields from tok_state structure which are now
      used unused:
      
      * altwarning: "Issue warning if alternate tabs don't match"
      * alterror: "Issue error if alternate tabs don't match"
      * alttabsize: "Alternate tab spacing"
      
      Replace alttabsize variable with ALTTABSIZE define.
      f2ddc6ac
  37. 15 Kas, 2017 1 kayıt (commit)
    • Victor Stinner's avatar
      bpo-32030: Split Py_Main() into subfunctions (#4399) · f7e5b56c
      Victor Stinner yazdı
      * Don't use "Python runtime" anymore to parse command line options or
        to get environment variables: pymain_init() is now a strict
        separation.
      * Use an error message rather than "crashing" directly with
        Py_FatalError(). Limit the number of calls to Py_FatalError(). It
        prepares the code to handle errors more nicely later.
      * Warnings options (-W, PYTHONWARNINGS) and "XOptions" (-X) are now
        only added to the sys module once Python core is properly
        initialized.
      * _PyMain is now the well identified owner of some important strings
        like: warnings options, XOptions, and the "program name". The
        program name string is now properly freed at exit.
        pymain_free() is now responsible to free the "command" string.
      * Rename most methods in Modules/main.c to use a "pymain_" prefix to
        avoid conflits and ease debug.
      * Replace _Py_CommandLineDetails_INIT with memset(0)
      * Reorder a lot of code to fix the initialization ordering. For
        example, initializing standard streams now comes before parsing
        PYTHONWARNINGS.
      * Py_Main() now handles errors when adding warnings options and
        XOptions.
      * Add _PyMem_GetDefaultRawAllocator() private function.
      * Cleanup _PyMem_Initialize(): remove useless global constants: move
        them into _PyMem_Initialize().
      * Call _PyRuntime_Initialize() as soon as possible:
        _PyRuntime_Initialize() now returns an error message on failure.
      * Add _PyInitError structure and following macros:
      
        * _Py_INIT_OK()
        * _Py_INIT_ERR(msg)
        * _Py_INIT_USER_ERR(msg): "user" error, don't abort() in that case
        * _Py_INIT_FAILED(err)
      f7e5b56c
  38. 11 Kas, 2017 1 kayıt (commit)
  39. 06 Eki, 2017 1 kayıt (commit)