tests.py 15.8 KB
Newer Older
1
# -*- coding:utf-8 -*-
2 3
from __future__ import unicode_literals

4
import logging
5
import warnings
6

7 8
from admin_scripts.tests import AdminScriptTestCase

9
from django.core import mail
10
from django.core.files.temp import NamedTemporaryFile
11
from django.test import RequestFactory, TestCase, override_settings
12
from django.test.utils import patch_logger
13
from django.utils.deprecation import RemovedInNextVersionWarning
14
from django.utils.encoding import force_text
15 16 17
from django.utils.log import (
    AdminEmailHandler, CallbackFilter, RequireDebugFalse, RequireDebugTrue,
)
18
from django.utils.six import StringIO
19

20 21
from .logconfig import MyEmailBackend

22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41
# logging config prior to using filter with mail_admins
OLD_LOGGING = {
    'version': 1,
    'disable_existing_loggers': False,
    'handlers': {
        'mail_admins': {
            'level': 'ERROR',
            'class': 'django.utils.log.AdminEmailHandler'
        }
    },
    'loggers': {
        'django.request': {
            'handlers': ['mail_admins'],
            'level': 'ERROR',
            'propagate': True,
        },
    }
}


42
class LoggingFiltersTest(TestCase):
43 44 45 46 47
    def test_require_debug_false_filter(self):
        """
        Test the RequireDebugFalse filter class.
        """
        filter_ = RequireDebugFalse()
48 49

        with self.settings(DEBUG=True):
50
            self.assertEqual(filter_.filter("record is not used"), False)
51 52

        with self.settings(DEBUG=False):
53
            self.assertEqual(filter_.filter("record is not used"), True)
54

55
    def test_require_debug_true_filter(self):
56
        """
57
        Test the RequireDebugTrue filter class.
58
        """
59
        filter_ = RequireDebugTrue()
60

61 62
        with self.settings(DEBUG=True):
            self.assertEqual(filter_.filter("record is not used"), True)
63

64 65
        with self.settings(DEBUG=False):
            self.assertEqual(filter_.filter("record is not used"), False)
66

Jason Myers's avatar
Jason Myers committed
67

68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88
class DefaultLoggingTest(TestCase):
    def setUp(self):
        self.logger = logging.getLogger('django')
        self.old_stream = self.logger.handlers[0].stream

    def tearDown(self):
        self.logger.handlers[0].stream = self.old_stream

    def test_django_logger(self):
        """
        The 'django' base logger only output anything when DEBUG=True.
        """
        output = StringIO()
        self.logger.handlers[0].stream = output
        self.logger.error("Hey, this is an error.")
        self.assertEqual(output.getvalue(), '')

        with self.settings(DEBUG=True):
            self.logger.error("Hey, this is an error.")
            self.assertEqual(output.getvalue(), 'Hey, this is an error.\n')

Jason Myers's avatar
Jason Myers committed
89

90 91
class WarningLoggerTests(TestCase):
    """
92 93
    Tests that warnings output for RemovedInDjangoXXWarning (XX being the next
    Django version) is enabled and captured to the logging system
94 95
    """
    def setUp(self):
96
        # If tests are invoke with "-Wall" (or any -W flag actually) then
97 98
        # warning logging gets disabled (see configure_logging in django/utils/log.py).
        # However, these tests expect warnings to be logged, so manually force warnings
99 100 101
        # to the logs. Use getattr() here because the logging capture state is
        # undocumented and (I assume) brittle.
        self._old_capture_state = bool(getattr(logging, '_warnings_showwarning', False))
102 103
        logging.captureWarnings(True)

104 105 106
        # this convoluted setup is to avoid printing this deprecation to
        # stderr during test running - as the test runner forces deprecations
        # to be displayed at the global py.warnings level
107
        self.logger = logging.getLogger('py.warnings')
108 109 110 111 112 113
        self.outputs = []
        self.old_streams = []
        for handler in self.logger.handlers:
            self.old_streams.append(handler.stream)
            self.outputs.append(StringIO())
            handler.stream = self.outputs[-1]
114 115

    def tearDown(self):
116 117
        for i, handler in enumerate(self.logger.handlers):
            self.logger.handlers[i].stream = self.old_streams[i]
118

119
        # Reset warnings state.
120
        logging.captureWarnings(self._old_capture_state)
121

122 123
    @override_settings(DEBUG=True)
    def test_warnings_capture(self):
124 125 126 127 128
        with warnings.catch_warnings():
            warnings.filterwarnings('always')
            warnings.warn('Foo Deprecated', RemovedInNextVersionWarning)
            output = force_text(self.outputs[0].getvalue())
            self.assertIn('Foo Deprecated', output)
129 130

    def test_warnings_capture_debug_false(self):
131 132 133 134 135
        with warnings.catch_warnings():
            warnings.filterwarnings('always')
            warnings.warn('Foo Deprecated', RemovedInNextVersionWarning)
            output = force_text(self.outputs[0].getvalue())
            self.assertNotIn('Foo Deprecated', output)
136

137 138 139 140 141 142 143 144 145 146
    @override_settings(DEBUG=True)
    def test_error_filter_still_raises(self):
        with warnings.catch_warnings():
            warnings.filterwarnings(
                'error',
                category=RemovedInNextVersionWarning
            )
            with self.assertRaises(RemovedInNextVersionWarning):
                warnings.warn('Foo Deprecated', RemovedInNextVersionWarning)

147

148 149 150 151 152 153 154 155 156 157
class CallbackFilterTest(TestCase):
    def test_sense(self):
        f_false = CallbackFilter(lambda r: False)
        f_true = CallbackFilter(lambda r: True)

        self.assertEqual(f_false.filter("record"), False)
        self.assertEqual(f_true.filter("record"), True)

    def test_passes_on_record(self):
        collector = []
158

159 160 161 162 163 164 165 166
        def _callback(record):
            collector.append(record)
            return True
        f = CallbackFilter(_callback)

        f.filter("a record")

        self.assertEqual(collector, ["a record"])
167 168 169


class AdminEmailHandlerTest(TestCase):
170
    logger = logging.getLogger('django.request')
171

172
    def get_admin_email_handler(self, logger):
173
        # Inspired from views/views.py: send_log()
174 175 176 177 178
        # ensuring the AdminEmailHandler does not get filtered out
        # even with DEBUG=True.
        admin_email_handler = [
            h for h in logger.handlers
            if h.__class__.__name__ == "AdminEmailHandler"
179
        ][0]
180 181
        return admin_email_handler

182 183 184 185
    def test_fail_silently(self):
        admin_email_handler = self.get_admin_email_handler(self.logger)
        self.assertTrue(admin_email_handler.connection().fail_silently)

186
    @override_settings(
187
        ADMINS=[('whatever admin', 'admin@example.com')],
188
        EMAIL_SUBJECT_PREFIX='-SuperAwesomeSubject-'
189
    )
190 191 192 193 194 195 196 197 198 199
    def test_accepts_args(self):
        """
        Ensure that user-supplied arguments and the EMAIL_SUBJECT_PREFIX
        setting are used to compose the email subject.
        Refs #16736.
        """
        message = "Custom message that says '%s' and '%s'"
        token1 = 'ping'
        token2 = 'pong'

200
        admin_email_handler = self.get_admin_email_handler(self.logger)
201 202
        # Backup then override original filters
        orig_filters = admin_email_handler.filters
203 204
        try:
            admin_email_handler.filters = []
205

206
            self.logger.error(message, token1, token2)
207

208 209 210 211 212 213 214 215 216
            self.assertEqual(len(mail.outbox), 1)
            self.assertEqual(mail.outbox[0].to, ['admin@example.com'])
            self.assertEqual(mail.outbox[0].subject,
                             "-SuperAwesomeSubject-ERROR: Custom message that says 'ping' and 'pong'")
        finally:
            # Restore original filters
            admin_email_handler.filters = orig_filters

    @override_settings(
217
        ADMINS=[('whatever admin', 'admin@example.com')],
218
        EMAIL_SUBJECT_PREFIX='-SuperAwesomeSubject-',
219
        INTERNAL_IPS=['127.0.0.1'],
220
    )
221 222 223 224 225 226 227 228
    def test_accepts_args_and_request(self):
        """
        Ensure that the subject is also handled if being
        passed a request object.
        """
        message = "Custom message that says '%s' and '%s'"
        token1 = 'ping'
        token2 = 'pong'
229

230
        admin_email_handler = self.get_admin_email_handler(self.logger)
231 232 233 234 235 236
        # Backup then override original filters
        orig_filters = admin_email_handler.filters
        try:
            admin_email_handler.filters = []
            rf = RequestFactory()
            request = rf.get('/')
237
            self.logger.error(message, token1, token2,
238 239 240 241 242 243 244 245 246 247 248 249
                extra={
                    'status_code': 403,
                    'request': request,
                }
            )
            self.assertEqual(len(mail.outbox), 1)
            self.assertEqual(mail.outbox[0].to, ['admin@example.com'])
            self.assertEqual(mail.outbox[0].subject,
                             "-SuperAwesomeSubject-ERROR (internal IP): Custom message that says 'ping' and 'pong'")
        finally:
            # Restore original filters
            admin_email_handler.filters = orig_filters
250 251

    @override_settings(
252
        ADMINS=[('admin', 'admin@example.com')],
253 254
        EMAIL_SUBJECT_PREFIX='',
        DEBUG=False,
255
    )
256 257 258 259 260 261
    def test_subject_accepts_newlines(self):
        """
        Ensure that newlines in email reports' subjects are escaped to avoid
        AdminErrorHandler to fail.
        Refs #17281.
        """
262 263
        message = 'Message \r\n with newlines'
        expected_subject = 'ERROR: Message \\r\\n with newlines'
264 265 266

        self.assertEqual(len(mail.outbox), 0)

267
        self.logger.error(message)
268 269

        self.assertEqual(len(mail.outbox), 1)
270 271
        self.assertNotIn('\n', mail.outbox[0].subject)
        self.assertNotIn('\r', mail.outbox[0].subject)
272 273 274
        self.assertEqual(mail.outbox[0].subject, expected_subject)

    @override_settings(
275 276 277
        ADMINS=(('admin', 'admin@example.com'),),
        EMAIL_SUBJECT_PREFIX='',
        DEBUG=False,
278
    )
279 280 281 282 283 284 285 286 287 288 289 290
    def test_truncate_subject(self):
        """
        RFC 2822's hard limit is 998 characters per line.
        So, minus "Subject: ", the actual subject must be no longer than 989
        characters.
        Refs #17281.
        """
        message = 'a' * 1000
        expected_subject = 'ERROR: aa' + 'a' * 980

        self.assertEqual(len(mail.outbox), 0)

291
        self.logger.error(message)
292 293 294

        self.assertEqual(len(mail.outbox), 1)
        self.assertEqual(mail.outbox[0].subject, expected_subject)
295

296
    @override_settings(
297
        ADMINS=[('admin', 'admin@example.com')],
298
        DEBUG=False,
299
    )
300 301 302 303 304 305 306 307 308 309
    def test_uses_custom_email_backend(self):
        """
        Refs #19325
        """
        message = 'All work and no play makes Jack a dull boy'
        admin_email_handler = self.get_admin_email_handler(self.logger)
        mail_admins_called = {'called': False}

        def my_mail_admins(*args, **kwargs):
            connection = kwargs['connection']
310
            self.assertIsInstance(connection, MyEmailBackend)
311 312 313 314 315 316 317
            mail_admins_called['called'] = True

        # Monkeypatches
        orig_mail_admins = mail.mail_admins
        orig_email_backend = admin_email_handler.email_backend
        mail.mail_admins = my_mail_admins
        admin_email_handler.email_backend = (
318
            'logging_tests.logconfig.MyEmailBackend')
319 320 321 322 323 324 325 326 327

        try:
            self.logger.error(message)
            self.assertTrue(mail_admins_called['called'])
        finally:
            # Revert Monkeypatches
            mail.mail_admins = orig_mail_admins
            admin_email_handler.email_backend = orig_email_backend

328
    @override_settings(
329
        ADMINS=[('whatever admin', 'admin@example.com')],
330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347
    )
    def test_emit_non_ascii(self):
        """
        #23593 - AdminEmailHandler should allow Unicode characters in the
        request.
        """
        handler = self.get_admin_email_handler(self.logger)
        record = self.logger.makeRecord('name', logging.ERROR, 'function', 'lno', 'message', None, None)
        rf = RequestFactory()
        url_path = '/º'
        record.request = rf.get(url_path)
        handler.emit(record)
        self.assertEqual(len(mail.outbox), 1)
        msg = mail.outbox[0]
        self.assertEqual(msg.to, ['admin@example.com'])
        self.assertEqual(msg.subject, "[Django] ERROR (EXTERNAL IP): message")
        self.assertIn("path:%s" % url_path, msg.body)

348
    @override_settings(
349
        MANAGERS=[('manager', 'manager@example.com')],
350 351 352 353 354 355 356 357 358 359 360 361 362 363
        DEBUG=False,
    )
    def test_customize_send_mail_method(self):
        class ManagerEmailHandler(AdminEmailHandler):
            def send_mail(self, subject, message, *args, **kwargs):
                mail.mail_managers(subject, message, *args, connection=self.connection(), **kwargs)

        handler = ManagerEmailHandler()
        record = self.logger.makeRecord('name', logging.ERROR, 'function', 'lno', 'message', None, None)
        self.assertEqual(len(mail.outbox), 0)
        handler.emit(record)
        self.assertEqual(len(mail.outbox), 1)
        self.assertEqual(mail.outbox[0].to, ['manager@example.com'])

364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386

class SettingsConfigTest(AdminScriptTestCase):
    """
    Test that accessing settings in a custom logging handler does not trigger
    a circular import error.
    """
    def setUp(self):
        log_config = """{
    'version': 1,
    'handlers': {
        'custom_handler': {
            'level': 'INFO',
            'class': 'logging_tests.logconfig.MyHandler',
        }
    }
}"""
        self.write_settings('settings.py', sdict={'LOGGING': log_config})

    def tearDown(self):
        self.remove_settings('settings.py')

    def test_circular_dependency(self):
        # validate is just an example command to trigger settings configuration
387
        out, err = self.run_manage(['check'])
388
        self.assertNoOutput(err)
389
        self.assertOutput(out, "System check identified no issues (0 silenced).")
390 391 392 393 394 395 396


def dictConfig(config):
    dictConfig.called = True
dictConfig.called = False


397
class SetupConfigureLogging(TestCase):
398
    """
399
    Test that calling django.setup() initializes the logging configuration.
400
    """
401 402
    @override_settings(LOGGING_CONFIG='logging_tests.tests.dictConfig',
                       LOGGING=OLD_LOGGING)
403
    def test_configure_initializes_logging(self):
404 405
        from django import setup
        setup()
406
        self.assertTrue(dictConfig.called)
407 408


409
@override_settings(DEBUG=True, ROOT_URLCONF='logging_tests.urls')
410 411 412
class SecurityLoggerTest(TestCase):

    def test_suspicious_operation_creates_log_message(self):
413
        with patch_logger('django.security.SuspiciousOperation', 'error') as calls:
414
            self.client.get('/suspicious/')
415 416
            self.assertEqual(len(calls), 1)
            self.assertEqual(calls[0], 'dubious')
417 418

    def test_suspicious_operation_uses_sublogger(self):
419
        with patch_logger('django.security.DisallowedHost', 'error') as calls:
420
            self.client.get('/suspicious_spec/')
421 422
            self.assertEqual(len(calls), 1)
            self.assertEqual(calls[0], 'dubious')
423 424

    @override_settings(
425
        ADMINS=[('admin', 'admin@example.com')],
426 427 428 429 430 431
        DEBUG=False,
    )
    def test_suspicious_email_admins(self):
        self.client.get('/suspicious/')
        self.assertEqual(len(mail.outbox), 1)
        self.assertIn('path:/suspicious/,', mail.outbox[0].body)
432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455


class SettingsCustomLoggingTest(AdminScriptTestCase):
    """
    Test that using a logging defaults are still applied when using a custom
    callable in LOGGING_CONFIG (i.e., logging.config.fileConfig).
    """
    def setUp(self):
        logging_conf = """
[loggers]
keys=root
[handlers]
keys=stream
[formatters]
keys=simple
[logger_root]
handlers=stream
[handler_stream]
class=StreamHandler
formatter=simple
args=(sys.stdout,)
[formatter_simple]
format=%(message)s
"""
456
        self.temp_file = NamedTemporaryFile()
457 458 459
        self.temp_file.write(logging_conf.encode('utf-8'))
        self.temp_file.flush()
        sdict = {'LOGGING_CONFIG': '"logging.config.fileConfig"',
460
                 'LOGGING': 'r"%s"' % self.temp_file.name}
461 462 463 464 465 466 467
        self.write_settings('settings.py', sdict=sdict)

    def tearDown(self):
        self.temp_file.close()
        self.remove_settings('settings.py')

    def test_custom_logging(self):
468
        out, err = self.run_manage(['check'])
469 470
        self.assertNoOutput(err)
        self.assertOutput(out, "System check identified no issues (0 silenced).")