Skip to content
Projeler
Gruplar
Parçacıklar
Yardım
Yükleniyor...
Oturum aç / Kaydol
Gezinmeyi değiştir
D
django
Proje
Proje
Ayrıntılar
Etkinlik
Cycle Analytics
Depo (repository)
Depo (repository)
Dosyalar
Kayıtlar (commit)
Dallar (branch)
Etiketler
Katkıda bulunanlar
Grafik
Karşılaştır
Grafikler
Konular (issue)
0
Konular (issue)
0
Liste
Pano
Etiketler
Kilometre Taşları
Birleştirme (merge) Talepleri
0
Birleştirme (merge) Talepleri
0
CI / CD
CI / CD
İş akışları (pipeline)
İşler
Zamanlamalar
Grafikler
Paketler
Paketler
Wiki
Wiki
Parçacıklar
Parçacıklar
Üyeler
Üyeler
Collapse sidebar
Close sidebar
Etkinlik
Grafik
Grafikler
Yeni bir konu (issue) oluştur
İşler
Kayıtlar (commit)
Konu (issue) Panoları
Kenar çubuğunu aç
Batuhan Osman TASKAYA
django
Commits
9f2e8b5b
Kaydet (Commit)
9f2e8b5b
authored
Nis 24, 2017
tarafından
Carles Pina Estany
Kaydeden (comit)
Simon Charette
Nis 24, 2017
Dosyalara gözat
Seçenekler
Dosyalara Gözat
İndir
Eposta Yamaları
Sade Fark
Fixed #28120 -- Checked that CharField.max_length is not a boolean.
üst
851874fe
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
18 additions
and
1 deletion
+18
-1
AUTHORS
AUTHORS
+1
-0
__init__.py
django/db/models/fields/__init__.py
+2
-1
test_ordinary_fields.py
tests/invalid_models_tests/test_ordinary_fields.py
+15
-0
No files found.
AUTHORS
Dosyayı görüntüle @
9f2e8b5b
...
@@ -140,6 +140,7 @@ answer newbie questions, and generally made Django that much better:
...
@@ -140,6 +140,7 @@ answer newbie questions, and generally made Django that much better:
Cameron Knight (ckknight)
Cameron Knight (ckknight)
Can Burak Çilingir <canburak@cs.bilgi.edu.tr>
Can Burak Çilingir <canburak@cs.bilgi.edu.tr>
Carl Meyer <carl@oddbird.net>
Carl Meyer <carl@oddbird.net>
Carles Pina i Estany <carles@pina.cat>
Carlos Eduardo de Paula <carlosedp@gmail.com>
Carlos Eduardo de Paula <carlosedp@gmail.com>
Carlos Matías de la Torre <cmdelatorre@gmail.com>
Carlos Matías de la Torre <cmdelatorre@gmail.com>
Carlton Gibson <carlton.gibson@noumenal.es>
Carlton Gibson <carlton.gibson@noumenal.es>
...
...
django/db/models/fields/__init__.py
Dosyayı görüntüle @
9f2e8b5b
...
@@ -1040,7 +1040,8 @@ class CharField(Field):
...
@@ -1040,7 +1040,8 @@ class CharField(Field):
id
=
'fields.E120'
,
id
=
'fields.E120'
,
)
)
]
]
elif
not
isinstance
(
self
.
max_length
,
int
)
or
self
.
max_length
<=
0
:
elif
(
not
isinstance
(
self
.
max_length
,
int
)
or
isinstance
(
self
.
max_length
,
bool
)
or
self
.
max_length
<=
0
):
return
[
return
[
checks
.
Error
(
checks
.
Error
(
"'max_length' must be a positive integer."
,
"'max_length' must be a positive integer."
,
...
...
tests/invalid_models_tests/test_ordinary_fields.py
Dosyayı görüntüle @
9f2e8b5b
...
@@ -139,6 +139,21 @@ class CharFieldTests(TestCase):
...
@@ -139,6 +139,21 @@ class CharFieldTests(TestCase):
]
]
self
.
assertEqual
(
errors
,
expected
)
self
.
assertEqual
(
errors
,
expected
)
def
test_str_max_length_type
(
self
):
class
Model
(
models
.
Model
):
field
=
models
.
CharField
(
max_length
=
True
)
field
=
Model
.
_meta
.
get_field
(
'field'
)
errors
=
field
.
check
()
expected
=
[
Error
(
"'max_length' must be a positive integer."
,
obj
=
field
,
id
=
'fields.E121'
),
]
self
.
assertEqual
(
errors
,
expected
)
def
test_non_iterable_choices
(
self
):
def
test_non_iterable_choices
(
self
):
class
Model
(
models
.
Model
):
class
Model
(
models
.
Model
):
field
=
models
.
CharField
(
max_length
=
10
,
choices
=
'bad'
)
field
=
models
.
CharField
(
max_length
=
10
,
choices
=
'bad'
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment