Kaydet (Commit) bfd42392 authored tarafından Ed Morley's avatar Ed Morley Kaydeden (comit) Tim Graham

Simplified tests with assertDoesNotOptimize().

üst 90db4bb0
...@@ -209,12 +209,7 @@ class OptimizerTests(SimpleTestCase): ...@@ -209,12 +209,7 @@ class OptimizerTests(SimpleTestCase):
[], [],
) )
# This should not work - FK should block it # This should not work - FK should block it
self.assertOptimizesTo( self.assertDoesNotOptimize(
[
migrations.CreateModel("Foo", [("name", models.CharField(max_length=255))]),
migrations.CreateModel("Bar", [("other", models.ForeignKey("testapp.Foo", models.CASCADE))]),
migrations.DeleteModel("Foo"),
],
[ [
migrations.CreateModel("Foo", [("name", models.CharField(max_length=255))]), migrations.CreateModel("Foo", [("name", models.CharField(max_length=255))]),
migrations.CreateModel("Bar", [("other", models.ForeignKey("testapp.Foo", models.CASCADE))]), migrations.CreateModel("Bar", [("other", models.ForeignKey("testapp.Foo", models.CASCADE))]),
...@@ -245,12 +240,7 @@ class OptimizerTests(SimpleTestCase): ...@@ -245,12 +240,7 @@ class OptimizerTests(SimpleTestCase):
app_label="testapp", app_label="testapp",
) )
# This should not work - bases should block it # This should not work - bases should block it
self.assertOptimizesTo( self.assertDoesNotOptimize(
[
migrations.CreateModel("Foo", [("name", models.CharField(max_length=255))]),
migrations.CreateModel("Bar", [("size", models.IntegerField())], bases=("testapp.Foo", )),
migrations.DeleteModel("Foo"),
],
[ [
migrations.CreateModel("Foo", [("name", models.CharField(max_length=255))]), migrations.CreateModel("Foo", [("name", models.CharField(max_length=255))]),
migrations.CreateModel("Bar", [("size", models.IntegerField())], bases=("testapp.Foo", )), migrations.CreateModel("Bar", [("size", models.IntegerField())], bases=("testapp.Foo", )),
...@@ -315,12 +305,7 @@ class OptimizerTests(SimpleTestCase): ...@@ -315,12 +305,7 @@ class OptimizerTests(SimpleTestCase):
AddField should NOT optimize into CreateModel if it's an FK to a model AddField should NOT optimize into CreateModel if it's an FK to a model
that's between them. that's between them.
""" """
self.assertOptimizesTo( self.assertDoesNotOptimize(
[
migrations.CreateModel("Foo", [("name", models.CharField(max_length=255))]),
migrations.CreateModel("Link", [("url", models.TextField())]),
migrations.AddField("Foo", "link", models.ForeignKey("migrations.Link", models.CASCADE)),
],
[ [
migrations.CreateModel("Foo", [("name", models.CharField(max_length=255))]), migrations.CreateModel("Foo", [("name", models.CharField(max_length=255))]),
migrations.CreateModel("Link", [("url", models.TextField())]), migrations.CreateModel("Link", [("url", models.TextField())]),
...@@ -335,14 +320,7 @@ class OptimizerTests(SimpleTestCase): ...@@ -335,14 +320,7 @@ class OptimizerTests(SimpleTestCase):
""" """
# Note: The middle model is not actually a valid through model, # Note: The middle model is not actually a valid through model,
# but that doesn't matter, as we never render it. # but that doesn't matter, as we never render it.
self.assertOptimizesTo( self.assertDoesNotOptimize(
[
migrations.CreateModel("Foo", [("name", models.CharField(max_length=255))]),
migrations.CreateModel("LinkThrough", []),
migrations.AddField(
"Foo", "link", models.ManyToManyField("migrations.Link", through="migrations.LinkThrough")
),
],
[ [
migrations.CreateModel("Foo", [("name", models.CharField(max_length=255))]), migrations.CreateModel("Foo", [("name", models.CharField(max_length=255))]),
migrations.CreateModel("LinkThrough", []), migrations.CreateModel("LinkThrough", []),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment