Fixed #23995 -- Removed unnecessary calls to self.client.logout() in tests.

tests/admin_custom_urls/tests.py

@@ -22,9 +22,6 @@ class AdminCustomUrlsTest(TestCase):
     def setUp(self):
         self.client.login(username='super', password='secret')
 
-    def tearDown(self):
-        self.client.logout()
-
     def test_basic_add_GET(self):
         """
         Ensure GET on the add_view works.
@@ -91,9 +88,6 @@ class CustomRedirects(TestCase):
     def setUp(self):
         self.client.login(username='super', password='secret')
 
-    def tearDown(self):
-        self.client.logout()
-
     def test_post_save_add_redirect(self):
         """
         Ensures that ModelAdmin.response_post_save_add() controls the

tests/admin_inlines/tests.py

@@ -36,9 +36,6 @@ class TestInline(TestCase):
         self.assertEqual(result, True)
         self.factory = RequestFactory()
 
-    def tearDown(self):
-        self.client.logout()
-
     def test_can_delete(self):
         """
         can_delete should be passed to inlineformset factory.
@@ -359,9 +356,6 @@ class TestInlineMedia(TestCase):
         result = self.client.login(username='super', password='secret')
         self.assertEqual(result, True)
 
-    def tearDown(self):
-        self.client.logout()
-
     def test_inline_media_only_base(self):
         holder = Holder(dummy=13)
         holder.save()
@@ -438,9 +432,6 @@ class TestInlineProtectedOnDelete(TestCase):
         result = self.client.login(username='super', password='secret')
         self.assertEqual(result, True)
 
-    def tearDown(self):
-        self.client.logout()
-
     def test_deleting_inline_with_protected_delete_does_not_validate(self):
         lotr = Novel.objects.create(name='Lord of the rings')
         chapter = Chapter.objects.create(novel=lotr, name='Many Meetings')
@@ -514,9 +505,6 @@ class TestInlinePermissions(TestCase):
             self.client.login(username='admin', password='secret'),
             True)
 
-    def tearDown(self):
-        self.client.logout()
-
     def test_inline_add_m2m_noperm(self):
         response = self.client.get('/admin/admin_inlines/author/add/')
         # No change permission on books, so no inline

tests/admin_widgets/tests.py

@@ -190,9 +190,6 @@ class AdminForeignKeyWidgetChangeList(DjangoTestCase):
     def setUp(self):
         self.client.login(username="super", password="secret")
 
-    def tearDown(self):
-        self.client.logout()
-
     def test_changelist_ForeignKey(self):
         response = self.client.get('/admin_widgets/car/')
         self.assertContains(response, '/auth/user/add/')
@@ -206,9 +203,6 @@ class AdminForeignKeyRawIdWidget(DjangoTestCase):
     def setUp(self):
         self.client.login(username="super", password="secret")
 
-    def tearDown(self):
-        self.client.logout()
-
     def test_nonexistent_target_id(self):
         band = models.Band.objects.create(name='Bogey Blues')
         pk = band.pk

tests/generic_inline_admin/tests.py

@@ -41,9 +41,6 @@ class GenericAdminViewTest(TestCase):
         m.save()
         self.png_media_pk = m.pk
 
-    def tearDown(self):
-        self.client.logout()
-
     def test_basic_add_GET(self):
         """
         A smoke test to ensure GET on the add_view works.
@@ -137,9 +134,6 @@ class GenericInlineAdminParametersTest(TestCase):
         self.client.login(username='super', password='secret')
         self.factory = RequestFactory()
 
-    def tearDown(self):
-        self.client.logout()
-
     def _create_object(self, model):
         """
         Create a model with an attached Media object via GFK. We can't
@@ -286,9 +280,6 @@ class GenericInlineAdminWithUniqueTogetherTest(TestCase):
     def setUp(self):
         self.client.login(username='super', password='secret')
 
-    def tearDown(self):
-        self.client.logout()
-
     def test_add(self):
         category_id = Category.objects.create(name='male').pk
         post_data = {