Skip to content
Projeler
Gruplar
Parçacıklar
Yardım
Yükleniyor...
Oturum aç / Kaydol
Gezinmeyi değiştir
D
django
Proje
Proje
Ayrıntılar
Etkinlik
Cycle Analytics
Depo (repository)
Depo (repository)
Dosyalar
Kayıtlar (commit)
Dallar (branch)
Etiketler
Katkıda bulunanlar
Grafik
Karşılaştır
Grafikler
Konular (issue)
0
Konular (issue)
0
Liste
Pano
Etiketler
Kilometre Taşları
Birleştirme (merge) Talepleri
0
Birleştirme (merge) Talepleri
0
CI / CD
CI / CD
İş akışları (pipeline)
İşler
Zamanlamalar
Grafikler
Paketler
Paketler
Wiki
Wiki
Parçacıklar
Parçacıklar
Üyeler
Üyeler
Collapse sidebar
Close sidebar
Etkinlik
Grafik
Grafikler
Yeni bir konu (issue) oluştur
İşler
Kayıtlar (commit)
Konu (issue) Panoları
Kenar çubuğunu aç
Batuhan Osman TASKAYA
django
Commits
d4eefc7e
Kaydet (Commit)
d4eefc7e
authored
Agu 18, 2016
tarafından
Loïc Bistuer
Kaydeden (comit)
GitHub
Agu 18, 2016
Dosyalara gözat
Seçenekler
Dosyalara Gözat
İndir
Eposta Yamaları
Sade Fark
Fixed #27073 -- Removed duplicated managers in `Model._meta.managers`.
üst
8cd900c8
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
24 additions
and
1 deletion
+24
-1
options.py
django/db/models/options.py
+6
-1
1.10.1.txt
docs/releases/1.10.1.txt
+2
-0
tests.py
tests/managers_regress/tests.py
+16
-0
No files found.
django/db/models/options.py
Dosyayı görüntüle @
d4eefc7e
...
...
@@ -369,11 +369,16 @@ class Options(object):
@cached_property
def
managers
(
self
):
managers
=
[]
seen_managers
=
set
()
bases
=
(
b
for
b
in
self
.
model
.
mro
()
if
hasattr
(
b
,
'_meta'
))
for
depth
,
base
in
enumerate
(
bases
):
for
manager
in
base
.
_meta
.
local_managers
:
if
manager
.
name
in
seen_managers
:
continue
manager
=
copy
.
copy
(
manager
)
manager
.
model
=
self
.
model
seen_managers
.
add
(
manager
.
name
)
managers
.
append
((
depth
,
manager
.
creation_counter
,
manager
))
# Used for deprecation of legacy manager inheritance,
...
...
@@ -387,7 +392,7 @@ class Options(object):
@cached_property
def
managers_map
(
self
):
return
{
manager
.
name
:
manager
for
manager
in
reversed
(
self
.
managers
)
}
return
{
manager
.
name
:
manager
for
manager
in
self
.
managers
}
@cached_property
def
base_manager
(
self
):
...
...
docs/releases/1.10.1.txt
Dosyayı görüntüle @
d4eefc7e
...
...
@@ -56,3 +56,5 @@ Bugfixes
* Reallowed the ``{% for %}`` tag to unpack any iterable (:ticket:`27058`).
* Fixed ``makemigrations`` crash if a database is read-only (:ticket:`27054`).
* Removed duplicated managers in ``Model._meta.managers`` (:ticket:`27073`).
tests/managers_regress/tests.py
Dosyayı görüntüle @
d4eefc7e
...
...
@@ -286,6 +286,22 @@ class TestManagerInheritance(TestCase):
self
.
assertIsInstance
(
MTIModel
.
_base_manager
,
CustomManager
)
def
test_manager_no_duplicates
(
self
):
class
CustomManager
(
models
.
Manager
):
pass
class
AbstractModel
(
models
.
Model
):
custom_manager
=
models
.
Manager
()
class
Meta
:
abstract
=
True
class
TestModel
(
AbstractModel
):
custom_manager
=
CustomManager
()
self
.
assertEqual
(
TestModel
.
_meta
.
managers
,
(
TestModel
.
custom_manager
,))
self
.
assertEqual
(
TestModel
.
_meta
.
managers_map
,
{
'custom_manager'
:
TestModel
.
custom_manager
})
@isolate_apps
(
'managers_regress'
)
class
TestManagerDeprecations
(
TestCase
):
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment