Kaydet (Commit) d82ee32a authored tarafından David Szotten's avatar David Szotten Kaydeden (comit) Tim Graham

Fixed #27889 -- Fixed incorrect check error if ModelAdmin.ordering refers to 'pk'.

üst 7588d7e4
...@@ -465,7 +465,8 @@ class BaseModelAdminChecks: ...@@ -465,7 +465,8 @@ class BaseModelAdminChecks:
else: else:
if field_name.startswith('-'): if field_name.startswith('-'):
field_name = field_name[1:] field_name = field_name[1:]
if field_name == 'pk':
return []
try: try:
model._meta.get_field(field_name) model._meta.get_field(field_name)
except FieldDoesNotExist: except FieldDoesNotExist:
......
...@@ -794,7 +794,7 @@ class OrderingCheckTests(CheckTestCase): ...@@ -794,7 +794,7 @@ class OrderingCheckTests(CheckTestCase):
def test_valid_case(self): def test_valid_case(self):
class TestModelAdmin(ModelAdmin): class TestModelAdmin(ModelAdmin):
ordering = ('name',) ordering = ('name', 'pk')
self.assertIsValid(TestModelAdmin, ValidationTestModel) self.assertIsValid(TestModelAdmin, ValidationTestModel)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment