Kaydet (Commit) 2981d013 authored tarafından Sumit Sahrawat's avatar Sumit Sahrawat

Fix remove_volume return value

Signed-off-by: 's avatarSumit Sahrawat <sumit.sahrawat.apm13@iitbhu.ac.in>
üst bd948be7
......@@ -33,4 +33,3 @@ class VolumeApiMixin(object):
url = self._url('/volumes/{0}', name)
resp = self._delete(url)
self._raise_for_status(resp)
return True
......@@ -780,8 +780,7 @@ Remove a volume. Similar to the `docker volume rm` command.
* name (str): The volume's name
**Returns** (bool): True on successful removal. Failure will raise a
`docker.errors.APIError` exception.
Failure to remove will raise a `docker.errors.APIError` exception.
## rename
......
......@@ -47,8 +47,7 @@ class TestVolumes(helpers.BaseTestCase):
name = 'shootthebullet'
self.tmp_volumes.append(name)
self.client.create_volume(name)
result = self.client.remove_volume(name)
self.assertTrue(result)
self.client.remove_volume(name)
def test_remove_nonexistent_volume(self):
name = 'shootthebullet'
......
......@@ -89,8 +89,7 @@ class VolumeTest(DockerClientTest):
@base.requires_api_version('1.21')
def test_remove_volume(self):
name = 'perfectcherryblossom'
result = self.client.remove_volume(name)
self.assertTrue(result)
self.client.remove_volume(name)
args = fake_request.call_args
self.assertEqual(args[0][0], 'DELETE')
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment