Kaydet (Commit) 764d7b38 authored tarafından Joffrey F's avatar Joffrey F

Support version parameter in `Client.from_env`

Signed-off-by: 's avatarJoffrey F <joffrey@docker.com>
üst d33e0695
......@@ -114,7 +114,8 @@ class Client(
@classmethod
def from_env(cls, **kwargs):
return cls(**kwargs_from_env(**kwargs))
version = kwargs.pop('version', None)
return cls(version=version, **kwargs_from_env(**kwargs))
def _retrieve_server_version(self):
try:
......
......@@ -25,6 +25,14 @@ class ClientTest(base.BaseTestCase):
client = Client.from_env()
self.assertEqual(client.base_url, "https://192.168.59.103:2376")
def test_from_env_with_version(self):
os.environ.update(DOCKER_HOST='tcp://192.168.59.103:2376',
DOCKER_CERT_PATH=TEST_CERT_DIR,
DOCKER_TLS_VERIFY='1')
client = Client.from_env(version='2.32')
self.assertEqual(client.base_url, "https://192.168.59.103:2376")
self.assertEqual(client._version, '2.32')
class DisableSocketTest(base.BaseTestCase):
class DummySocket(object):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment