Unverified Kaydet (Commit) 9e052ae0 authored tarafından elextr's avatar elextr Kaydeden (comit) GitHub

Remove requirement to fail build on aggregate return

Returning large aggregates as values is a potential performance problem, but preventing all aggregate returns is inappropriate because:

1. returning small aggregates that are mostly handled as complete objects as return values often makes code clearer.

2. Modern (well not so modern actually) ABIs allow for small aggregates to be returned in registers, so forcing all returns to memory is actually likely to be slower.

3. if code review does not notice a large aggregate return and nobody notices a performance issue then it doesn't matter
üst 7e1ab31c
......@@ -21,7 +21,7 @@ install:
- sudo apt-get install -y --no-install-recommends doxygen
- sudo apt-get install -y python-lxml
before_script:
- export CFLAGS="-g -O2 -Werror=pointer-arith -Werror=aggregate-return -Werror=implicit-function-declaration"
- export CFLAGS="-g -O2 -Werror=pointer-arith -Werror=implicit-function-declaration"
script:
- NOCONFIGURE=1 ./autogen.sh
- >
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment