• Eike Rathke's avatar
    Resolves: tdf#116242 handle negated diacritics correctly and show checkbox · 86bfe605
    Eike Rathke yazdı
     This is a combination of 2 commits.
    
    Resolves: tdf#116242 handle negated diacritics correctly and show checkbox
    
    The "ignore diacritics" implementation is not only about CTL,
    whatever its names suggest. It uses an ICU
    "NFD; [:M:] Remove; NFC" transliteration that decomposes and
    removes *any* diacritic.
    
    Thus treat it as such and don't hide the checkbox if CTL is not
    enabled, but more important preset the sensitive values, and
    handle the UI vs implementation oddity correctly; UI "sensitive" /
    code "include" means to *not* *ignore*, obtain the proper negated
    value from the checkbox.
    
    Unfortunately the setting is stored in the configuration, so an
    update will still present the user with an unchecked
    Diacritics-sensitive box s/he has to enable once.
    
    The actual failure (diacritics always ignored) is a fallout from
    
        commit d4064927
        AuthorDate: Tue Oct 3 10:26:28 2017 -0800
        CommitDate: Thu Oct 26 17:24:26 2017 +0200
    
            tdf#111846 Find & Replace: Rename diacritics and kashida options
    
    (cherry picked from commit d99ae18b)
    
    Change IsIgnoreDiacritics_CTL default to false, tdf#116242 follow-up
    
    And adapt description to reality.
    
    (cherry picked from commit a8959a26)
    
    ab35b74f4cbe7dc91fd0570adcc634faba96b5de
    
    Change-Id: I65f2a23b66370fdfe2d170c17c7736a3b4177192
    Reviewed-on: https://gerrit.libreoffice.org/50914Tested-by: 's avatarJenkins <ci@libreoffice.org>
    Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.co.uk>
    (cherry picked from commit 31f3e18d)
    86bfe605
srchdlg.cxx 75.9 KB