• Michael Stahl's avatar
    coverity#705391: xmloff: XMLMergeElemTransformerContext misuse of enum · 76dce95e
    Michael Stahl yazdı
    The enum types XMLElemTransformerAction and XMLAttrTransformerAction
    use the same integer values so a mixture of values from these 2 in one
    switch is very suspicious.  In the various *ActionTable arrays in
    OOo2Oasis/Oasis2OOo there is just one such array that mixes values from
    the 2 enums, and that is just the values that coverity complains about.
    
    The XML_ETACTION_EXTRACT_CHARACTERS was added at a later date in commits
    8d374c039e7d349141befe3c9ef97f82f42bfa7
    2685b93a
    7d2405a5
    c276550e
    
    ...but it turns out that the XMLAttrTransformerAction ones are handled
    in StartElement() and ProcessAttrs() methods but the
    XMLElemTransformerAction ones are handled in CreateChildContext()
    methods so probably the XML_ATACTION_MOVE_FROM_ELEM* values are in
    the wrong enum.
    
    Change-Id: Ib1791f6eafac4fb1e99334f41c17a90cfb076359
    76dce95e
ElemTransformerAction.hxx 5.66 KB