Kaydet (Commit) 04041bf0 authored tarafından Caolán McNamara's avatar Caolán McNamara Kaydeden (comit) Andras Timar

coverity#1311944 Logically dead code

for the record its a SwFormatChg we get here at the crash time

regression from

commit 7de992bc
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Mon Jul 13 12:38:18 2015 +0100

    fix a11y crash seen on close of tdf#92573

    its not the reported crash, which has "gone away" which might
    be a duplicate of tdf#90502

    the switch only handled RES_TITLE_CHANGED and RES_DESCRIPTION_CHANGED so if its
    anything else, e.g. OBJ_DYING, then don't attempt GetNoTextNode

Change-Id: I290d6e633811423c3acc198aba7a60943518ec4a
(cherry picked from commit 34c0b886)
Reviewed-on: https://gerrit.libreoffice.org/17137Reviewed-by: 's avatarEike Rathke <erack@redhat.com>
Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
üst b72173c8
...@@ -102,7 +102,7 @@ void SwAccessibleNoTextFrame::Modify( const SfxPoolItem* pOld, const SfxPoolItem ...@@ -102,7 +102,7 @@ void SwAccessibleNoTextFrame::Modify( const SfxPoolItem* pOld, const SfxPoolItem
return; // probably was deleted - avoid doing anything return; // probably was deleted - avoid doing anything
} }
if (nWhich != RES_TITLE_CHANGED || nWhich != RES_DESCRIPTION_CHANGED) if (nWhich != RES_TITLE_CHANGED && nWhich != RES_DESCRIPTION_CHANGED)
return; return;
const SwNoTextNode *pNd = GetNoTextNode(); const SwNoTextNode *pNd = GetNoTextNode();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment