loplugin:constfields in xmlhelp

Change-Id: Ia8eda3075b0387ec3a5ed6267f1dfcfb3a8cf782
Reviewed-on: https://gerrit.libreoffice.org/60426
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

xmlhelp/source/cxxhelp/inc/tvread.hxx

@@ -269,7 +269,7 @@ namespace treeview {
         css::uno::Reference< css::ucb::XSimpleFileAccess3 >   m_xSFA;
 
         IteratorState                                                               m_eState;
-        OUString                                                               m_aLanguage;
+        OUString const                                                              m_aLanguage;
 
         css::uno::Sequence< css::uno::Reference
             < css::deployment::XPackage > >                              m_aUserPackagesSeq;

xmlhelp/source/cxxhelp/provider/content.cxx

@@ -137,9 +137,9 @@ private:
 
     uno::Reference< uno::XComponentContext >     m_xContext;
     uno::Reference< ucb::XContentProvider >      m_xProvider;
-    uno::Sequence< beans::Property >             m_seq;
-    URLParameter                                 m_aURLParameter;
-    Databases*                                   m_pDatabases;
+    uno::Sequence< beans::Property > const       m_seq;
+    URLParameter const                           m_aURLParameter;
+    Databases* const                             m_pDatabases;
 
 public:
 
@@ -174,9 +174,9 @@ private:
 
     uno::Reference< uno::XComponentContext >     m_xContext;
     uno::Reference< ucb::XContentProvider >      m_xProvider;
-    uno::Sequence< beans::Property >             m_seq;
+    uno::Sequence< beans::Property > const       m_seq;
     URLParameter                                 m_aURLParameter;
-    Databases*                                   m_pDatabases;
+    Databases* const                             m_pDatabases;
 
 public:
 

xmlhelp/source/cxxhelp/provider/databases.hxx

@@ -57,10 +57,10 @@ namespace chelp {
     {
     private:
 
-        OUString m_aStartId;
-        OUString m_aProgramSwitch;
-        OUString m_aTitle;
-        int m_nOrder;
+        OUString const m_aStartId;
+        OUString const m_aProgramSwitch;
+        OUString const m_aTitle;
+        int const m_nOrder;
 
     public:
 
@@ -233,7 +233,7 @@ namespace chelp {
         css::uno::Reference< css::lang::XMultiComponentFactory > m_xSMgr;
         css::uno::Reference< css::ucb::XSimpleFileAccess3 >      m_xSFA;
 
-        bool   m_bShowBasic;
+        bool const   m_bShowBasic;
 
         std::vector<char> m_vCustomCSSDoc;
         OUString m_aCSS;
@@ -387,7 +387,7 @@ namespace chelp {
             const css::uno::Reference< css::deployment::XPackage >& xPackage,
             OUString* o_pExtensionPath, OUString* o_pExtensionRegistryPath );
 
-        bool                                                                        m_bHelpText;
+        bool const                                                                        m_bHelpText;
 
     }; // end class DataBaseIterator
 

xmlhelp/source/cxxhelp/provider/db.hxx

@@ -51,7 +51,7 @@ namespace helpdatafileproxy {
 
     class Hdf
     {
-        OUString       m_aFileURL;
+        OUString const       m_aFileURL;
         std::unique_ptr<StringToDataMap>   m_pStringToDataMap;
         std::unique_ptr<StringToValPosMap> m_pStringToValPosMap;
         css::uno::Reference< css::ucb::XSimpleFileAccess3 >

xmlhelp/source/cxxhelp/provider/provider.cxx

@@ -48,7 +48,6 @@ using namespace chelp;
 ContentProvider::ContentProvider( const uno::Reference< uno::XComponentContext >& rxContext )
     : ::ucbhelper::ContentProviderImplHelper( rxContext )
     , isInitialized( false )
-    , m_aScheme(MYUCP_URL_SCHEME)
 {
 }
 
@@ -169,7 +168,7 @@ ContentProvider::queryContent(
         const uno::Reference< ucb::XContentIdentifier >& xCanonicId )
 {
     if ( !xCanonicId->getContentProviderScheme()
-             .equalsIgnoreAsciiCase( m_aScheme ) )
+             .equalsIgnoreAsciiCase( MYUCP_URL_SCHEME ) )
     {   // Wrong URL-scheme
         throw ucb::IllegalIdentifierException();
     }

xmlhelp/source/cxxhelp/provider/provider.hxx

@@ -119,7 +119,6 @@ namespace chelp {
 
     private:
         bool                           isInitialized;
-        OUString                       m_aScheme;
         std::unique_ptr<Databases>     m_pDatabases;
         css::uno::Reference<css::container::XContainer> m_xContainer;
 

xmlhelp/source/cxxhelp/provider/resultsetbase.hxx

@@ -387,7 +387,7 @@ namespace chelp {
         ItemSet                             m_aItems;
         std::vector<OUString>               m_aPath;
 
-        css::uno::Sequence< css::beans::Property >           m_sProperty;
+        css::uno::Sequence< css::beans::Property > const          m_sProperty;
 
         osl::Mutex                          m_aMutex;
         std::unique_ptr<comphelper::OInterfaceContainerHelper2>   m_pDisposeEventListeners;

xmlhelp/source/cxxhelp/provider/resultsetforquery.hxx

@@ -45,7 +45,7 @@ namespace chelp {
 
     private:
 
-        URLParameter m_aURLParameter;
+        URLParameter const m_aURLParameter;
     };
 
 }

xmlhelp/source/cxxhelp/provider/urlparameter.hxx

@@ -169,7 +169,7 @@ namespace chelp {
         bool m_bHelpDataFileRead;
         bool m_bUseDB;
 
-        OUString  m_aURL;
+        OUString const m_aURL;
 
         OUString  m_aTag;
         OUString  m_aId;