Skip to content

C
core
Kaydet (Commit) 0b3a807e authored tarafından Caolán McNamara's avatar Caolán McNamara
Dosyalara gözat
Seçenekler

coverity#1338272 Uncaught exception 

Change-Id: I5b2b7044c77de899ce8dc1e44f3673835bd3ce4c
üst eb02a553
Hide whitespace changes
Inline Side-by-side
Showing with 49 additions and 41 deletions
registry/tools/regview.cxx
Dosyayı görüntüle @ 0b3a807e
...@@ -34,71 +34,79 @@ int main( int argc, char * argv[] ) ...@@ -34,71 +34,79 @@ int main( int argc, char * argv[] )
int __cdecl main( int argc, char * argv[] ) int __cdecl main( int argc, char * argv[] )
#endif #endif
{ {
RegHandle hReg; try
RegKeyHandle hRootKey, hKey;
if (argc < 2 || argc > 3)
{ {
fprintf(stderr, "using: regview registryfile [keyName]\n"); RegHandle hReg;
exit(1); RegKeyHandle hRootKey, hKey;
}
OUString regName( convertToFileUrl(argv[1], strlen(argv[1])) ); if (argc < 2 || argc > 3)
if (reg_openRegistry(regName.pData, &hReg, RegAccessMode::READONLY) != RegError::NO_ERROR) {
{ fprintf(stderr, "using: regview registryfile [keyName]\n");
fprintf(stderr, "open registry \"%s\" failed\n", argv[1]); exit(1);
exit(1); }
}
if (reg_openRootKey(hReg, &hRootKey) == RegError::NO_ERROR) OUString regName( convertToFileUrl(argv[1], strlen(argv[1])) );
{ if (reg_openRegistry(regName.pData, &hReg, RegAccessMode::READONLY) != RegError::NO_ERROR)
if (argc == 3)
{ {
OUString keyName( OUString::createFromAscii(argv[2]) ); fprintf(stderr, "open registry \"%s\" failed\n", argv[1]);
if (reg_openKey(hRootKey, keyName.pData, &hKey) == RegError::NO_ERROR) exit(1);
}
if (reg_openRootKey(hReg, &hRootKey) == RegError::NO_ERROR)
{
if (argc == 3)
{ {
if (reg_dumpRegistry(hKey) != RegError::NO_ERROR) OUString keyName( OUString::createFromAscii(argv[2]) );
if (reg_openKey(hRootKey, keyName.pData, &hKey) == RegError::NO_ERROR)
{ {
fprintf(stderr, "dumping registry \"%s\" failed\n", argv[1]); if (reg_dumpRegistry(hKey) != RegError::NO_ERROR)
} {
fprintf(stderr, "dumping registry \"%s\" failed\n", argv[1]);
}
if (reg_closeKey(hKey) != RegError::NO_ERROR) if (reg_closeKey(hKey) != RegError::NO_ERROR)
{
fprintf(stderr, "closing key \"%s\" of registry \"%s\" failed\n",
argv[2], argv[1]);
}
}
else
{ {
fprintf(stderr, "closing key \"%s\" of registry \"%s\" failed\n", fprintf(stderr, "key \"%s\" not exists in registry \"%s\"\n",
argv[2], argv[1]); argv[2], argv[1]);
} }
} }
else else
{ {
fprintf(stderr, "key \"%s\" not exists in registry \"%s\"\n", if (reg_dumpRegistry(hRootKey) != RegError::NO_ERROR)
argv[2], argv[1]); {
fprintf(stderr, "dumping registry \"%s\" failed\n", argv[1]);
}
}
if (reg_closeKey(hRootKey) != RegError::NO_ERROR)
{
fprintf(stderr, "closing root key of registry \"%s\" failed\n", argv[1]);
} }
} }
else else
{ {
if (reg_dumpRegistry(hRootKey) != RegError::NO_ERROR) fprintf(stderr, "open root key of registry \"%s\" failed\n", argv[1]);
{
fprintf(stderr, "dumping registry \"%s\" failed\n", argv[1]);
}
} }
if (reg_closeKey(hRootKey) != RegError::NO_ERROR) if (reg_closeRegistry(hReg) != RegError::NO_ERROR)
{ {
fprintf(stderr, "closing root key of registry \"%s\" failed\n", argv[1]); fprintf(stderr, "closing registry \"%s\" failed\n", argv[1]);
exit(1);
} }
}
else
{
fprintf(stderr, "open root key of registry \"%s\" failed\n", argv[1]);
}
if (reg_closeRegistry(hReg) != RegError::NO_ERROR) return 0;
}
catch (std::exception& e)
{ {
fprintf(stderr, "closing registry \"%s\" failed\n", argv[1]); fprintf(stderr, "failure: \"%s\"\n", e.what());
exit(1); return 1;
} }
return 0;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment