kill TF_POOLABLE, step 1: error if unset

cui/source/dialogs/iconcdlg.cxx

@@ -982,7 +982,7 @@ const sal_uInt16* IconChoiceDialog::GetInputRanges( const SfxItemPool& rPool )
 
     // remove double Id's
 #ifndef TF_POOLABLE
-    if ( rPool.HasMap() )
+#error "TF_POOLABLE should always be set."
 #endif
     {
         nCount = aUS.Count();

sfx2/source/appl/appmain.cxx

@@ -86,6 +86,8 @@ static SfxItemInfo const aItemInfos[] =
 {
     { 0, 0 }
 };
+#else
+#error "TF_POOLABLE should always be set."
 #endif
 
 //===================================================================

sfx2/source/control/dispatch.cxx

@@ -1003,7 +1003,7 @@ void MappedPut_Impl( SfxAllItemSet &rSet, const SfxPoolItem &rItem )
 #ifdef TF_POOLABLE
     if ( pPool->IsSlot(nWhich) )
 #else
-    if ( pPool->HasMap() && pPool->IsSlot(nWhich) )
+#error "TF_POOLABLE should always be set."
 #endif
         nWhich = pPool->GetWhich(nWhich);
     rSet.Put( rItem, nWhich );

sfx2/source/dialog/tabdlg.cxx

@@ -1642,7 +1642,7 @@ const sal_uInt16* SfxTabDialog::GetInputRanges( const SfxItemPool& rPool )
 
     //! Remove duplicated Ids?
 #ifndef TF_POOLABLE
-    if ( rPool.HasMap() )
+#error "TF_POOLABLE should always be set."
 #endif
     {
         nCount = aUS.Count();

svl/inc/svl/itempool.hxx

@@ -114,7 +114,7 @@ class SVL_DLLPUBLIC SfxItemPool
 #ifdef TF_POOLABLE
     const SfxItemInfo*              pItemInfos;
 #else
-    sal_uInt16*                         pSlotIds;
+#error "TF_POOLABLE should always be set."
 #endif
     SfxItemPool_Impl*               pImp;
     SfxPoolItem**                   ppStaticDefaults;
@@ -164,10 +164,12 @@ public:
                                                  sal_uInt16 nStart, sal_uInt16 nEnd,
 #ifdef TF_POOLABLE
                                                  const SfxItemInfo *pItemInfos,
+#else
+#error "TF_POOLABLE should always be set."
 #endif
                                                  SfxPoolItem **pDefaults = 0,
 #ifndef TF_POOLABLE
-                                                 sal_uInt16 *pSlotIds = 0,
+#error "TF_POOLABLE should always be set."
 #endif
                                                  bool bLoadRefCounts = true );
 protected:
@@ -246,9 +248,7 @@ public:
     void                            SetItemInfos( const SfxItemInfo *pInfos )
                                     { pItemInfos = pInfos; }
 #else
-    int                             HasMap() const { return 0 != pSlotIds; }
-    void                            SetMap( sal_uInt16 *pNewSlotIds )
-                                    { pSlotIds = pNewSlotIds; }
+#error "TF_POOLABLE should always be set."
 #endif
     sal_uInt16                          GetWhich( sal_uInt16 nSlot, sal_Bool bDeep = sal_True ) const;
     sal_uInt16                          GetSlotId( sal_uInt16 nWhich, sal_Bool bDeep = sal_True ) const;

svl/inc/svl/slstitm.hxx

@@ -56,7 +56,7 @@ public:
     const std::vector<String>& GetList() const;
 
 #ifndef TF_POOLABLE
-    virtual int             IsPoolable() const;
+#error "TF_POOLABLE should always be set."
 #endif
 
     // String-Separator: \n

svl/source/items/itempool.cxx

@@ -110,12 +110,14 @@ SfxItemPool::SfxItemPool
     sal_uInt16              nEndWhich,      /* letzte Which-Id des Pools */
 #ifdef TF_POOLABLE
     const SfxItemInfo*  pInfos,         /* SID-Map und Item-Flags */
+#else
+#error "TF_POOLABLE should always be set."
 #endif
     SfxPoolItem**       pDefaults,      /* Pointer auf statische Defaults,
                                            wird direkt vom Pool referenziert,
                                            jedoch kein Eigent"umer"ubergang */
 #ifndef TF_POOLABLE
-    sal_uInt16*             pSlotIdArray,   /* Zuordnung von Slot-Ids zu Which-Ids */
+#error "TF_POOLABLE should always be set."
 #endif
     bool                bLoadRefCounts  /* Ref-Counts mitladen oder auf 1 setzen */
 )
@@ -157,7 +159,7 @@ SfxItemPool::SfxItemPool
 #ifdef TF_POOLABLE
     pItemInfos(pInfos),
 #else
-    pSlotIds(pSlotIdArray),
+#error "TF_POOLABLE should always be set."
 #endif
     pImp( new SfxItemPool_Impl( nStart, nEnd ) ),
     ppStaticDefaults(0),
@@ -218,7 +220,7 @@ SfxItemPool::SfxItemPool
 #ifdef TF_POOLABLE
     pItemInfos(rPool.pItemInfos),
 #else
-    pSlotIds(rPool.pSlotIds),
+#error "TF_POOLABLE should always be set."
 #endif
     pImp( new SfxItemPool_Impl( nStart, nEnd ) ),
     ppStaticDefaults(0),
@@ -793,6 +795,8 @@ const SfxPoolItem& SfxItemPool::Put( const SfxPoolItem& rItem, sal_uInt16 nWhich
                     *pNewItem == rItem,
                     nWhich, "unequal items in Put(): no operator==?" );
     }
+#else
+#error "TF_POOLABLE should always be set."
 #endif
 #endif
     AddRef( *pNewItem, pImp->nInitRefCount );
@@ -1008,13 +1012,7 @@ sal_uInt16 SfxItemPool::GetWhich( sal_uInt16 nSlotId, sal_Bool bDeep ) const
         if ( pItemInfos[nOfs]._nSID == nSlotId )
             return nOfs + nStart;
 #else
-    if ( pSlotIds )
-    {
-        sal_uInt16 nCount = nEnd - nStart + 1;
-        for ( sal_uInt16 nOfs = 0; nOfs < nCount; ++nOfs )
-            if ( pSlotIds[nOfs] == nSlotId )
-                return nOfs + nStart;
-    }
+#error "TF_POOLABLE should always be set."
 #endif
     if ( pSecondary && bDeep )
         return pSecondary->GetWhich(nSlotId);
@@ -1040,9 +1038,7 @@ sal_uInt16 SfxItemPool::GetSlotId( sal_uInt16 nWhich, sal_Bool bDeep ) const
     sal_uInt16 nSID = pItemInfos[nWhich - nStart]._nSID;
     return nSID ? nSID : nWhich;
 #else
-    else if ( pSlotIds )
-        return pSlotIds[nWhich - nStart];
-    return nWhich;
+#error "TF_POOLABLE should always be set."
 #endif
 }
 
@@ -1059,13 +1055,7 @@ sal_uInt16 SfxItemPool::GetTrueWhich( sal_uInt16 nSlotId, sal_Bool bDeep ) const
         if ( pItemInfos[nOfs]._nSID == nSlotId )
             return nOfs + nStart;
 #else
-    if ( pSlotIds )
-    {
-        sal_uInt16 nCount = nEnd - nStart + 1;
-        for ( sal_uInt16 nOfs = 0; nOfs < nCount; ++nOfs )
-            if ( pSlotIds[nOfs] == nSlotId )
-                return nOfs + nStart;
-    }
+#error "TF_POOLABLE should always be set."
 #endif
     if ( pSecondary && bDeep )
         return pSecondary->GetTrueWhich(nSlotId);
@@ -1089,10 +1079,7 @@ sal_uInt16 SfxItemPool::GetTrueSlotId( sal_uInt16 nWhich, sal_Bool bDeep ) const
 #ifdef TF_POOLABLE
     return pItemInfos[nWhich - nStart]._nSID;
 #else
-    else if ( pSlotIds )
-        return pSlotIds[nWhich - nStart];
-    else
-        return 0;
+#error "TF_POOLABLE should always be set."
 #endif
 }
 // -----------------------------------------------------------------------

svl/source/items/poolio.cxx

@@ -199,7 +199,7 @@ SvStream &SfxItemPool::Store(SvStream &rStream) const
 #ifdef TF_POOLABLE
                 if ( *pArr && IsItemFlag(**ppDefItem, SFX_ITEM_POOLABLE) &&
 #else
-                if ( *pArr && (*ppDefItem)->IsPoolable() &&
+#error "TF_POOLABLE should always be set."
 #endif
                      pImp->bInSetItem == (*ppDefItem)->ISA(SfxSetItem) )
                 {

svl/source/items/poolitem.cxx

@@ -189,12 +189,7 @@ int SfxPoolItem::operator==( const SfxPoolItem& rCmp ) const
 
 // -----------------------------------------------------------------------
 #ifndef TF_POOLABLE
-
-int SfxPoolItem::IsPoolable() const
-{
-    DBG_CHKTHIS(SfxPoolItem, 0);
-    return sal_True;
-}
+#error "TF_POOLABLE should always be set."
 #endif
 
 // -----------------------------------------------------------------------