fix regression, some mutexes need to live longer

commit 6149da20
    replace misc double checked locking patterns
    ... with thread safe local statics

reintroduced bug #i77768# despite big comment

Change-Id: Ic6e204a277c8aa4f43c5fd15a42066c6f8a69dad
Reviewed-on: https://gerrit.libreoffice.org/38959Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

svl/source/numbers/zforlist.cxx

@@ -353,9 +353,9 @@ void SvNumberFormatter::ChangeIntl(LanguageType eLnge)
     // #i77768# Due to a static reference in the toolkit lib
     // we need a mutex that lives longer than the svl library.
     // Otherwise the dtor would use a destructed mutex!!
-    static ::osl::Mutex persistantMutex;
+    static osl::Mutex* persistentMutex(new osl::Mutex);
 
-    return persistantMutex;
+    return *persistentMutex;
 }
 
 

unotools/source/config/syslocaleoptions.cxx

@@ -526,9 +526,9 @@ Mutex& SvtSysLocaleOptions::GetMutex()
     // #i77768# Due to a static reference in the toolkit lib
     // we need a mutex that lives longer than the svl library.
     // Otherwise the dtor would use a destructed mutex!!
-    static Mutex persistentMutex;
+    static Mutex* persistentMutex(new Mutex);
 
-    return persistentMutex;
+    return *persistentMutex;
 }
 
 bool SvtSysLocaleOptions::IsModified()

unotools/source/misc/syslocale.cxx

@@ -137,9 +137,9 @@ Mutex& SvtSysLocale::GetMutex()
     // #i77768# Due to a static reference in the toolkit lib
     // we need a mutex that lives longer than the svl library.
     // Otherwise the dtor would use a destructed mutex!!
-    static Mutex persistentMutex;
+    static Mutex* persistentMutex(new Mutex);
 
-    return persistentMutex;
+    return *persistentMutex;
 }
 
 const LocaleDataWrapper& SvtSysLocale::GetLocaleData() const