Kaydet (Commit) 14377b33 authored tarafından Noel Grandin's avatar Noel Grandin

loplugin:useuniqueptr in SwXMLImport

Change-Id: I0c90d39c87bbd4a6edaa70b2413a64a41585a944
Reviewed-on: https://gerrit.libreoffice.org/57865
Tested-by: Jenkins
Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
üst 94e3568d
...@@ -59,6 +59,7 @@ ...@@ -59,6 +59,7 @@
#include <strings.hrc> #include <strings.hrc>
#include <svl/stritem.hxx> #include <svl/stritem.hxx>
#include "xmlimp.hxx" #include "xmlimp.hxx"
#include "xmlimpit.hxx"
#include "xmltexti.hxx" #include "xmltexti.hxx"
#include <list.hxx> #include <list.hxx>
#include <swdll.hxx> #include <swdll.hxx>
...@@ -358,7 +359,7 @@ void SwXMLDocStylesContext_Impl::EndElement() ...@@ -358,7 +359,7 @@ void SwXMLDocStylesContext_Impl::EndElement()
const SvXMLTokenMap& SwXMLImport::GetDocElemTokenMap() const SvXMLTokenMap& SwXMLImport::GetDocElemTokenMap()
{ {
if( !m_pDocElemTokenMap ) if( !m_pDocElemTokenMap )
m_pDocElemTokenMap = new SvXMLTokenMap( aDocTokenMap ); m_pDocElemTokenMap.reset( new SvXMLTokenMap( aDocTokenMap ) );
return *m_pDocElemTokenMap; return *m_pDocElemTokenMap;
} }
...@@ -436,9 +437,9 @@ SwXMLImport::~SwXMLImport() throw () ...@@ -436,9 +437,9 @@ SwXMLImport::~SwXMLImport() throw ()
SAL_WARN("sw", "endDocument skipped, dropping shapes now to avoid dangling SvTextShapeImportHelper pointing to this"); SAL_WARN("sw", "endDocument skipped, dropping shapes now to avoid dangling SvTextShapeImportHelper pointing to this");
ClearShapeImport(); ClearShapeImport();
} }
delete m_pDocElemTokenMap; m_pDocElemTokenMap.reset();
delete m_pTableElemTokenMap; m_pTableElemTokenMap.reset();
delete m_pTableCellAttrTokenMap; m_pTableCellAttrTokenMap.reset();
FinitItemImport(); FinitItemImport();
} }
......
...@@ -63,11 +63,11 @@ class SwXMLImport: public SvXMLImport ...@@ -63,11 +63,11 @@ class SwXMLImport: public SvXMLImport
{ {
std::unique_ptr<SwNodeIndex> m_pSttNdIdx; std::unique_ptr<SwNodeIndex> m_pSttNdIdx;
SvXMLUnitConverter *m_pTwipUnitConv; std::unique_ptr<SvXMLUnitConverter> m_pTwipUnitConv;
SvXMLImportItemMapper *m_pTableItemMapper;// paragraph item import std::unique_ptr<SvXMLImportItemMapper> m_pTableItemMapper;// paragraph item import
SvXMLTokenMap *m_pDocElemTokenMap; std::unique_ptr<SvXMLTokenMap> m_pDocElemTokenMap;
SvXMLTokenMap *m_pTableElemTokenMap; std::unique_ptr<SvXMLTokenMap> m_pTableElemTokenMap;
SvXMLTokenMap *m_pTableCellAttrTokenMap; std::unique_ptr<SvXMLTokenMap> m_pTableCellAttrTokenMap;
rtl::Reference<SvXMLGraphicHelper> m_xGraphicStorageHandler; rtl::Reference<SvXMLGraphicHelper> m_xGraphicStorageHandler;
......
...@@ -318,21 +318,21 @@ SvXMLImportContextRef SwXMLItemSetContext_Impl::CreateChildContext( ...@@ -318,21 +318,21 @@ SvXMLImportContextRef SwXMLItemSetContext_Impl::CreateChildContext(
void SwXMLImport::InitItemImport() void SwXMLImport::InitItemImport()
{ {
m_pTwipUnitConv = new SvXMLUnitConverter( GetComponentContext(), m_pTwipUnitConv.reset( new SvXMLUnitConverter( GetComponentContext(),
util::MeasureUnit::TWIP, util::MeasureUnit::TWIP ); util::MeasureUnit::TWIP, util::MeasureUnit::TWIP ) );
m_xTableItemMap = new SvXMLItemMapEntries( aXMLTableItemMap ); m_xTableItemMap = new SvXMLItemMapEntries( aXMLTableItemMap );
m_xTableColItemMap = new SvXMLItemMapEntries( aXMLTableColItemMap ); m_xTableColItemMap = new SvXMLItemMapEntries( aXMLTableColItemMap );
m_xTableRowItemMap = new SvXMLItemMapEntries( aXMLTableRowItemMap ); m_xTableRowItemMap = new SvXMLItemMapEntries( aXMLTableRowItemMap );
m_xTableCellItemMap = new SvXMLItemMapEntries( aXMLTableCellItemMap ); m_xTableCellItemMap = new SvXMLItemMapEntries( aXMLTableCellItemMap );
m_pTableItemMapper = new SwXMLImportTableItemMapper_Impl( m_xTableItemMap ); m_pTableItemMapper.reset( new SwXMLImportTableItemMapper_Impl( m_xTableItemMap ) );
} }
void SwXMLImport::FinitItemImport() void SwXMLImport::FinitItemImport()
{ {
delete m_pTableItemMapper; m_pTableItemMapper.reset();
delete m_pTwipUnitConv; m_pTwipUnitConv.reset();
} }
SvXMLImportContext *SwXMLImport::CreateTableItemImportContext( SvXMLImportContext *SwXMLImport::CreateTableItemImportContext(
......
...@@ -152,7 +152,7 @@ static const SvXMLTokenMapEntry aTableCellAttrTokenMap[] = ...@@ -152,7 +152,7 @@ static const SvXMLTokenMapEntry aTableCellAttrTokenMap[] =
const SvXMLTokenMap& SwXMLImport::GetTableElemTokenMap() const SvXMLTokenMap& SwXMLImport::GetTableElemTokenMap()
{ {
if( !m_pTableElemTokenMap ) if( !m_pTableElemTokenMap )
m_pTableElemTokenMap = new SvXMLTokenMap( aTableElemTokenMap ); m_pTableElemTokenMap.reset(new SvXMLTokenMap( aTableElemTokenMap ));
return *m_pTableElemTokenMap; return *m_pTableElemTokenMap;
} }
...@@ -160,7 +160,7 @@ const SvXMLTokenMap& SwXMLImport::GetTableElemTokenMap() ...@@ -160,7 +160,7 @@ const SvXMLTokenMap& SwXMLImport::GetTableElemTokenMap()
const SvXMLTokenMap& SwXMLImport::GetTableCellAttrTokenMap() const SvXMLTokenMap& SwXMLImport::GetTableCellAttrTokenMap()
{ {
if( !m_pTableCellAttrTokenMap ) if( !m_pTableCellAttrTokenMap )
m_pTableCellAttrTokenMap = new SvXMLTokenMap( aTableCellAttrTokenMap ); m_pTableCellAttrTokenMap.reset(new SvXMLTokenMap( aTableCellAttrTokenMap ));
return *m_pTableCellAttrTokenMap; return *m_pTableCellAttrTokenMap;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment