Kaydet (Commit) 16846fd2 authored tarafından Jens Carl's avatar Jens Carl

Remove shared mxComponent in scimportdescriptorbaseobj

Change-Id: I11e80ca9e985650db783a8bee6b0334ec5be0d4c
Reviewed-on: https://gerrit.libreoffice.org/48885Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarJens Carl <j.carl43@gmx.de>
üst 300e9990
...@@ -26,8 +26,6 @@ using namespace com::sun::star; ...@@ -26,8 +26,6 @@ using namespace com::sun::star;
namespace sc_apitest namespace sc_apitest
{ {
#define NUMBER_OF_TESTS 1
class ScImportDescriptorBaseObj : public CalcUnoApiTest, public apitest::DatabaseImportDescriptor class ScImportDescriptorBaseObj : public CalcUnoApiTest, public apitest::DatabaseImportDescriptor
{ {
public: public:
...@@ -47,13 +45,9 @@ public: ...@@ -47,13 +45,9 @@ public:
CPPUNIT_TEST_SUITE_END(); CPPUNIT_TEST_SUITE_END();
private: private:
static sal_Int32 nTest; uno::Reference<lang::XComponent> mxComponent;
static uno::Reference<lang::XComponent> mxComponent;
}; };
sal_Int32 ScImportDescriptorBaseObj::nTest = 0;
uno::Reference<lang::XComponent> ScImportDescriptorBaseObj::mxComponent;
ScImportDescriptorBaseObj::ScImportDescriptorBaseObj() ScImportDescriptorBaseObj::ScImportDescriptorBaseObj()
: CalcUnoApiTest("/sc/qa/extras/testdocuments") : CalcUnoApiTest("/sc/qa/extras/testdocuments")
{ {
...@@ -61,10 +55,6 @@ ScImportDescriptorBaseObj::ScImportDescriptorBaseObj() ...@@ -61,10 +55,6 @@ ScImportDescriptorBaseObj::ScImportDescriptorBaseObj()
uno::Reference<uno::XInterface> ScImportDescriptorBaseObj::init() uno::Reference<uno::XInterface> ScImportDescriptorBaseObj::init()
{ {
// create a calc document
if (!mxComponent.is())
mxComponent = loadFromDesktop("private:factory/scalc");
uno::Reference<sheet::XSpreadsheetDocument> xDoc(mxComponent, UNO_QUERY_THROW); uno::Reference<sheet::XSpreadsheetDocument> xDoc(mxComponent, UNO_QUERY_THROW);
CPPUNIT_ASSERT_MESSAGE("no calc document", xDoc.is()); CPPUNIT_ASSERT_MESSAGE("no calc document", xDoc.is());
...@@ -77,10 +67,6 @@ uno::Reference<uno::XInterface> ScImportDescriptorBaseObj::init() ...@@ -77,10 +67,6 @@ uno::Reference<uno::XInterface> ScImportDescriptorBaseObj::init()
uno::Reference<uno::XInterface> ScImportDescriptorBaseObj::getXImportable() uno::Reference<uno::XInterface> ScImportDescriptorBaseObj::getXImportable()
{ {
// create a calc document
if (!mxComponent.is())
mxComponent = loadFromDesktop("private:factory/scalc");
uno::Reference<sheet::XSpreadsheetDocument> xDoc(mxComponent, UNO_QUERY_THROW); uno::Reference<sheet::XSpreadsheetDocument> xDoc(mxComponent, UNO_QUERY_THROW);
CPPUNIT_ASSERT_MESSAGE("no calc document", xDoc.is()); CPPUNIT_ASSERT_MESSAGE("no calc document", xDoc.is());
...@@ -94,19 +80,14 @@ uno::Reference<uno::XInterface> ScImportDescriptorBaseObj::getXImportable() ...@@ -94,19 +80,14 @@ uno::Reference<uno::XInterface> ScImportDescriptorBaseObj::getXImportable()
void ScImportDescriptorBaseObj::setUp() void ScImportDescriptorBaseObj::setUp()
{ {
nTest++;
CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS);
CalcUnoApiTest::setUp(); CalcUnoApiTest::setUp();
// create a calc document
mxComponent = loadFromDesktop("private:factory/scalc");
} }
void ScImportDescriptorBaseObj::tearDown() void ScImportDescriptorBaseObj::tearDown()
{ {
if (nTest == NUMBER_OF_TESTS) closeDocument(mxComponent);
{
closeDocument(mxComponent);
mxComponent.clear();
}
CalcUnoApiTest::tearDown(); CalcUnoApiTest::tearDown();
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment