cppcheck: Prefer prefix operator

Just replace the initial loop by a for range loop

Change-Id: I4c7e3be29f50b16e12cd82a39f53f6e03830a1d9
Reviewed-on: https://gerrit.libreoffice.org/41106Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

svx/source/dialog/searchcharmap.cxx

@@ -464,12 +464,8 @@ void SvxSearchCharSet::AppendCharToList(sal_UCS4 sChar)
 
 void SvxSearchCharSet::AppendCharList(std::vector<sal_UCS4> sList)
 {
-    std::vector<sal_UCS4>::iterator list_iter = sList.begin();
-    while(list_iter != sList.end())
-    {
-        AppendCharToList(*list_iter);
-        list_iter++;
-    }
+    for (auto& it : sList)
+        AppendCharToList(it);
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */