loplugin:countusersofdefaultparams in sd..slideshow

Change-Id: Iaf10935d8f231676333018a5954d97defe35acf6

sd/inc/sdpage.hxx

@@ -151,7 +151,7 @@ protected:
 
 public:
 
-    SdPage(SdDrawDocument& rNewDoc, bool bMasterPage=false);
+    SdPage(SdDrawDocument& rNewDoc, bool bMasterPage);
     virtual ~SdPage() override;
     virtual SdrPage* Clone() const override;
     virtual SdrPage* Clone(SdrModel* pNewModel) const override;

sd/qa/unit/filters-test.cxx

@@ -69,7 +69,7 @@ bool SdFiltersTest::load(const OUString &rFilter, const OUString &rURL,
         rUserData, OUString() ));
     const_cast<SfxFilter*>(pFilter.get())->SetVersion(nFilterVersion);
 
-    ::sd::DrawDocShellRef xDocShRef = new ::sd::DrawDocShell();
+    ::sd::DrawDocShellRef xDocShRef = new ::sd::DrawDocShell(SfxObjectCreateMode::EMBEDDED, false);
     SfxMedium* pSrcMed = new SfxMedium(rURL, StreamMode::STD_READ);
     pSrcMed->SetFilter(pFilter);
     bool bLoaded = xDocShRef->DoLoad(pSrcMed);

sd/qa/unit/sdmodeltestbase.hxx

@@ -134,7 +134,7 @@ protected:
         pFilter->SetVersion(SOFFICE_FILEFORMAT_CURRENT);
         std::shared_ptr<const SfxFilter> pFilt(pFilter);
 
-        ::sd::DrawDocShellRef xDocShRef = new ::sd::DrawDocShell();
+        ::sd::DrawDocShellRef xDocShRef = new ::sd::DrawDocShell(SfxObjectCreateMode::EMBEDDED, false);
         SfxMedium* pSrcMed = new SfxMedium(rURL, StreamMode::STD_READ, pFilt, pParams);
         if ( !xDocShRef->DoLoad(pSrcMed) || !xDocShRef.Is() )
         {

sd/source/filter/ppt/pptin.cxx

@@ -2772,7 +2772,7 @@ extern "C" SAL_DLLPUBLIC_EXPORT bool SAL_CALL TestImportPPT(const OUString &rURL
     xDocStream->SetVersion(xStorage->GetVersion());
     xDocStream->SetCryptMaskKey(xStorage->GetKey());
 
-    ::sd::DrawDocShellRef xDocShRef = new ::sd::DrawDocShell();
+    ::sd::DrawDocShellRef xDocShRef = new ::sd::DrawDocShell(SfxObjectCreateMode::EMBEDDED, false);
     SdDrawDocument *pDoc = xDocShRef->GetDoc();
 
     bool bRet = ImportPPT(pDoc, *xDocStream, *xStorage, aSrcMed);

sd/source/ui/animations/CustomAnimationDialog.hxx

@@ -142,7 +142,7 @@ class STLPropertySet;
 class CustomAnimationDialog : public TabDialog
 {
 public:
-    CustomAnimationDialog(vcl::Window* pParent, STLPropertySet* pSet, const OString& Page = OString());
+    CustomAnimationDialog(vcl::Window* pParent, STLPropertySet* pSet, const OString& Page);
     virtual ~CustomAnimationDialog() override;
     virtual void dispose() override;
 

sd/source/ui/inc/DrawDocShell.hxx

@@ -58,19 +58,19 @@ private:
 
 public:
     DrawDocShell (
-        SfxObjectCreateMode eMode = SfxObjectCreateMode::EMBEDDED,
-        bool bSdDataObj=false,
+        SfxObjectCreateMode eMode,
+        bool bSdDataObj,
         DocumentType=DocumentType::Impress);
 
     DrawDocShell (
         SfxModelFlags nModelCreationFlags,
-        bool bSdDataObj=false,
+        bool bSdDataObj,
         DocumentType=DocumentType::Impress);
 
     DrawDocShell (
         SdDrawDocument* pDoc,
-        SfxObjectCreateMode eMode = SfxObjectCreateMode::EMBEDDED,
-        bool bSdDataObj=false,
+        SfxObjectCreateMode eMode,
+        bool bSdDataObj,
         DocumentType=DocumentType::Impress);
     virtual ~DrawDocShell() override;
 

sd/source/ui/inc/DrawViewShell.hxx

@@ -88,8 +88,8 @@ public:
         SfxViewFrame* pFrame,
         ViewShellBase& rViewShellBase,
         vcl::Window* pParentWindow,
-        PageKind ePageKind = PageKind::Standard,
-        FrameView* pFrameView = nullptr);
+        PageKind ePageKind,
+        FrameView* pFrameView);
 
     virtual ~DrawViewShell() override;
 

sd/source/ui/inc/GraphicDocShell.hxx

@@ -46,13 +46,13 @@ public:
     SFX_DECL_OBJECTFACTORY();
 
     GraphicDocShell (
-        SfxObjectCreateMode eMode = SfxObjectCreateMode::EMBEDDED,
-        bool bSdDataObj=false,
+        SfxObjectCreateMode eMode,
+        bool bSdDataObj,
         DocumentType=DocumentType::Draw);
 
     GraphicDocShell (
         SfxModelFlags nModelCreationFlags,
-        bool bSdDataObj=false,
+        bool bSdDataObj,
         DocumentType=DocumentType::Draw);
 
     virtual ~GraphicDocShell() override;

sd/source/ui/inc/GraphicViewShell.hxx

@@ -59,7 +59,7 @@ public:
         SfxViewFrame* pFrame,
         ViewShellBase& rViewShellBase,
         vcl::Window* pParentWindow,
-        FrameView* pFrameView = nullptr);
+        FrameView* pFrameView);
 
     virtual ~GraphicViewShell() override;
 

sd/source/ui/inc/OutlineViewShell.hxx

@@ -56,7 +56,7 @@ public:
         SfxViewFrame* pFrame,
         ViewShellBase& rViewShellBase,
         vcl::Window* pParentWindow,
-        FrameView* pFrameView = nullptr);
+        FrameView* pFrameView);
 
     virtual ~OutlineViewShell() override;
 

sd/source/ui/inc/PresentationViewShell.hxx

@@ -38,7 +38,7 @@ private:
     static void InitInterface_Impl();
 
 public:
-    PresentationViewShell( SfxViewFrame* pFrame, ViewShellBase& rViewShellBase, vcl::Window* pParentWindow, FrameView* pFrameView = nullptr);
+    PresentationViewShell( SfxViewFrame* pFrame, ViewShellBase& rViewShellBase, vcl::Window* pParentWindow, FrameView* pFrameView);
     virtual ~PresentationViewShell() override;
 
     /** This method is used by a simple class that passes some

sd/source/ui/inc/dlgpage.hxx

@@ -43,7 +43,7 @@ private:
     sal_uInt16            mnTransparence;
 public:
 
-    SdPageDlg( SfxObjectShell* pDocSh, vcl::Window* pParent, const SfxItemSet* pAttr, bool bAreaPage = true );
+    SdPageDlg( SfxObjectShell* pDocSh, vcl::Window* pParent, const SfxItemSet* pAttr, bool bAreaPage );
     virtual ~SdPageDlg() override {};
 
     virtual void PageCreated(sal_uInt16 nId, SfxTabPage& rPage) override;

sd/source/ui/inc/optsitem.hxx

@@ -144,7 +144,7 @@ class SD_DLLPUBLIC SdOptionsLayoutItem : public SfxPoolItem
 public:
 
                             explicit SdOptionsLayoutItem();
-                            SdOptionsLayoutItem( SdOptions* pOpts, ::sd::FrameView* pView = nullptr );
+                            SdOptionsLayoutItem( SdOptions* pOpts, ::sd::FrameView* pView );
 
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = nullptr ) const override;
     virtual bool            operator==( const SfxPoolItem& ) const override;
@@ -177,7 +177,7 @@ class SD_DLLPUBLIC SdOptionsContentsItem : public SfxPoolItem
 {
 public:
 
-                            SdOptionsContentsItem( SdOptions* pOpts, ::sd::FrameView* pView = nullptr );
+                            SdOptionsContentsItem( SdOptions* pOpts, ::sd::FrameView* pView );
 
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = nullptr ) const override;
     virtual bool            operator==( const SfxPoolItem& ) const override;
@@ -324,7 +324,7 @@ class SD_DLLPUBLIC SdOptionsMiscItem : public SfxPoolItem
 public:
 
                             explicit SdOptionsMiscItem();
-                            SdOptionsMiscItem( SdOptions* pOpts, ::sd::FrameView* pView = nullptr );
+                            SdOptionsMiscItem( SdOptions* pOpts, ::sd::FrameView* pView );
 
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = nullptr ) const override;
     virtual bool            operator==( const SfxPoolItem& ) const override;
@@ -393,7 +393,7 @@ class SD_DLLPUBLIC SdOptionsSnapItem : public SfxPoolItem
 public:
 
                             explicit SdOptionsSnapItem();
-                            SdOptionsSnapItem( SdOptions* pOpts, ::sd::FrameView* pView = nullptr );
+                            SdOptionsSnapItem( SdOptions* pOpts, ::sd::FrameView* pView );
 
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = nullptr ) const override;
     virtual bool            operator==( const SfxPoolItem& ) const override;

sd/source/ui/inc/unomodel.hxx

@@ -131,8 +131,8 @@ private:
     sd::DrawViewShell* GetViewShell();
 
 public:
-    SdXImpressDocument( ::sd::DrawDocShell* pShell, bool bClipBoard = false ) throw();
-    SdXImpressDocument( SdDrawDocument* pDoc, bool bClipBoard = false ) throw();
+    SdXImpressDocument( ::sd::DrawDocShell* pShell, bool bClipBoard ) throw();
+    SdXImpressDocument( SdDrawDocument* pDoc, bool bClipBoard ) throw();
     virtual ~SdXImpressDocument() throw() override;
 
     static rtl::Reference< SdXImpressDocument > GetModel( SdDrawDocument* pDoc );

sd/source/ui/view/sdview3.cxx

@@ -680,7 +680,7 @@ bool View::InsertData( const TransferableDataHelper& rDataHelper,
 
         if( aDataHelper.GetSotStorageStream( SotClipboardFormatId::DRAWING, xStm ) )
         {
-            DrawDocShellRef xShell = new DrawDocShell(SfxObjectCreateMode::INTERNAL);
+            DrawDocShellRef xShell = new DrawDocShell(SfxObjectCreateMode::INTERNAL, false);
             xShell->DoInitNew();
 
             SdDrawDocument* pModel = xShell->GetDoc();

sfx2/source/appl/newhelp.hxx

@@ -565,7 +565,7 @@ class SfxAddHelpBookmarkDialog_Impl : public ModalDialog
 private:
     VclPtr<Edit> m_pTitleED;
 public:
-    SfxAddHelpBookmarkDialog_Impl( vcl::Window* pParent, bool bRename = true );
+    SfxAddHelpBookmarkDialog_Impl( vcl::Window* pParent, bool bRename );
     virtual ~SfxAddHelpBookmarkDialog_Impl() override;
     virtual void dispose() override;
 

sfx2/source/inc/templdgi.hxx

@@ -105,7 +105,7 @@ protected:
                 SvTreeListEntry* pTarget, SvTreeListEntry* pEntry,
                 SvTreeListEntry*& rpNewParent, sal_uIntPtr& rNewChildPos) override;
 public:
-    StyleTreeListBox_Impl( SfxCommonTemplateDialog_Impl* pParent, WinBits nWinStyle = 0);
+    StyleTreeListBox_Impl( SfxCommonTemplateDialog_Impl* pParent, WinBits nWinStyle);
 
     void Recalc();
 

slideshow/source/engine/transitions/spiralwipe.hxx

@@ -47,7 +47,7 @@ protected:
 class BoxSnakesWipe : public SpiralWipe
 {
 public:
-    BoxSnakesWipe( sal_Int32 nElements, bool fourBox = false )
+    BoxSnakesWipe( sal_Int32 nElements, bool fourBox )
         : SpiralWipe(nElements), m_fourBox(fourBox) {}
     virtual ::basegfx::B2DPolyPolygon operator () ( double t ) override;
 private:

slideshow/source/engine/transitions/waterfallwipe.hxx

@@ -31,7 +31,7 @@ namespace internal {
 class WaterfallWipe : public ParametricPolyPolygon
 {
 public:
-    WaterfallWipe( sal_Int32 nElements, bool flipOnYAxis = false );
+    WaterfallWipe( sal_Int32 nElements, bool flipOnYAxis );
     virtual ::basegfx::B2DPolyPolygon operator () ( double t ) override;
 private:
     bool m_flipOnYAxis;