loplugin:constantfunction: reportdesign

Change-Id: Ic94359c544034b9e6f09bd02a377d906a5b820e6

reportdesign/source/ui/inc/ReportController.hxx

@@ -318,7 +318,6 @@ namespace rptui
         DECL_LINK( OnClipboardChanged, void* );
         DECL_LINK( OnExecuteReport, void* );
         DECL_LINK( OnOpenHelpAgent, void* );
-        short saveModified();
         // all the features which should be handled by this class
         virtual void            describeSupportedFeatures() SAL_OVERRIDE;
         // state of a feature. 'feature' may be the handle of a ::com::sun::star::util::URL somebody requested a dispatch interface for OR a toolbar slot.

reportdesign/source/ui/inc/ReportWindow.hxx

@@ -68,9 +68,6 @@ namespace rptui
         OReportWindow(OScrollWindowHelper* _pParent,ODesignView* _pView);
         virtual ~OReportWindow();
 
-        /** late ctor
-        */
-        void initialize();
         // Window overrides
         virtual void Resize() SAL_OVERRIDE;
 

reportdesign/source/ui/inc/ViewsWindow.hxx

@@ -159,10 +159,6 @@ namespace rptui
 
         void resize(const OSectionWindow& _rSectionWindow);
 
-        /** late ctor
-        */
-        void initialize();
-
         inline OReportWindow*       getView()           const { return m_pParent; }
 
         /** removes the section at the given position.

reportdesign/source/ui/report/ReportController.cxx

@@ -1608,17 +1608,7 @@ void OReportController::Execute(sal_uInt16 _nId, const Sequence< PropertyValue >
         case SID_EDITDOC:
             if(isEditable())
             { // the state should be changed to not editable
-                switch (saveModified())
-                {
-                    case RET_CANCEL:
-                        // don't change anything here so return
-                        return;
-                    case RET_NO:
-                        setModified(sal_False);     // and we are not modified yet
-                        break;
-                    default:
-                        break;
-                }
+                setModified(sal_False);     // and we are not modified yet
             }
             setEditable(!isEditable());
             InvalidateAll();
@@ -1655,12 +1645,6 @@ void OReportController::Execute(sal_uInt16 _nId, const Sequence< PropertyValue >
     InvalidateFeature(_nId,Reference< XStatusListener >(),bForceBroadcast);
 }
 
-short OReportController::saveModified()
-{
-    return RET_NO;
-}
-
-
 void OReportController::impl_initialize( )
 {
     OReportController_BASE::impl_initialize();

reportdesign/source/ui/report/ReportWindow.cxx

@@ -89,11 +89,6 @@ OReportWindow::~OReportWindow()
         m_pReportListener->dispose();
 }
 
-void OReportWindow::initialize()
-{
-    m_aViewsWindow.initialize();
-}
-
 void OReportWindow::SetInsertObj( sal_uInt16 eObj,const OUString& _sShapeType )
 {
     m_aViewsWindow.SetInsertObj( eObj,_sShapeType);

reportdesign/source/ui/report/ScrollHelper.cxx

@@ -91,8 +91,6 @@ void OScrollWindowHelper::initialize()
 {
     uno::Reference<report::XReportDefinition> xReportDefinition = m_pParent->getController().getReportDefinition();
     m_pReportDefintionMultiPlexer = addStyleListener(xReportDefinition,this);
-
-    m_aReportWindow.initialize();
 }
 
 void OScrollWindowHelper::setTotalSize(sal_Int32 _nWidth ,sal_Int32 _nHeight)

reportdesign/source/ui/report/ViewsWindow.cxx

@@ -189,10 +189,6 @@ OViewsWindow::~OViewsWindow()
     m_aSections.clear();
 }
 
-void OViewsWindow::initialize()
-{
-}
-
 void OViewsWindow::impl_resizeSectionWindow(OSectionWindow& _rSectionWindow,Point& _rStartPoint,bool _bSet)
 {
     const uno::Reference< report::XSection> xSection = _rSectionWindow.getReportSection().getSection();