Kaydet (Commit) 1cc819c3 authored tarafından Jim Raykowski's avatar Jim Raykowski Kaydeden (comit) Noel Grandin

Don't use ToolBox::KeyInput for escape key press in GalleryToolBox

GalleryToolBox is used in the Gallery deck/panel in the sidebar.
Guidelines for keyboard navigation in the sidebar are that Escape from
content moves focus to content panel title or in absence of panel title
to the deck title or if sidebar is floating and the deck has only one
panel move focus to the tab bar settings menu button. This patch removes
ToolBox key input method from being used to handle escape key input in
GalleryToolBox. This allows sidebar focus manger to provide the correct
behavior.

Change-Id: Iaf6fb404aae784b1119b5477948c4edb674a972a
Reviewed-on: https://gerrit.libreoffice.org/62768Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
Tested-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
üst 2f88877a
......@@ -364,7 +364,10 @@ GalleryToolBox::GalleryToolBox( GalleryBrowser2* pParent ) :
void GalleryToolBox::KeyInput( const KeyEvent& rKEvt )
{
if( !static_cast< GalleryBrowser2* >( GetParent() )->KeyInput( rKEvt, this ) )
ToolBox::KeyInput( rKEvt );
{
if( KEY_ESCAPE != rKEvt.GetKeyCode().GetCode() )
ToolBox::KeyInput(rKEvt);
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment