Use typed ToolBox::SetCommandHdl Link

Change-Id: Ieee142ddebb288037647fb77bac6f11b9827c4a8

framework/inc/uielement/addonstoolbarmanager.hxx

@@ -60,7 +60,7 @@ class AddonsToolBarManager : public ToolBarManager
     protected:
         DECL_LINK_TYPED(Click, ToolBox *, void);
         DECL_LINK_TYPED(DoubleClick, ToolBox *, void);
-        DECL_LINK(Command, void *);
+        DECL_LINK_TYPED(Command, CommandEvent const *, void);
         DECL_LINK_TYPED(Select, ToolBox *, void);
         DECL_LINK_TYPED(Activate, ToolBox *, void);
         DECL_LINK_TYPED(Deactivate, ToolBox *, void);

framework/inc/uielement/toolbarmanager.hxx

@@ -126,7 +126,7 @@ class ToolBarManager : public ToolbarManager_Base
         typedef std::vector< ControllerParams > ControllerParamsVector;
 
     protected:
-        DECL_LINK( Command, CommandEvent * );
+        DECL_LINK_TYPED( Command, CommandEvent const *, void );
         PopupMenu * GetToolBarCustomMenu(ToolBox* pToolBar);
         DECL_LINK_TYPED(Click, ToolBox *, void);
         DECL_LINK_TYPED(DropdownClick, ToolBox *, void);

framework/source/uielement/addonstoolbarmanager.cxx

@@ -413,15 +413,8 @@ IMPL_LINK_NOARG_TYPED(AddonsToolBarManager, DoubleClick, ToolBox *, void)
     }
 }
 
-IMPL_LINK_NOARG(AddonsToolBarManager, Command)
-{
-    SolarMutexGuard g;
-
-    if ( m_bDisposed )
-        return 1;
-
-    return 0;
-}
+IMPL_LINK_NOARG_TYPED(AddonsToolBarManager, Command, CommandEvent const *, void)
+{}
 
 IMPL_LINK_NOARG_TYPED(AddonsToolBarManager, Select, ToolBox *, void)
 {

framework/source/uielement/toolbarmanager.cxx

@@ -285,7 +285,7 @@ void ToolBarManager::Destroy()
     m_pToolBar->SetDoubleClickHdl( Link<ToolBox *, void>() );
     m_pToolBar->SetStateChangedHdl( aEmpty );
     m_pToolBar->SetDataChangedHdl( aEmpty );
-    m_pToolBar->SetCommandHdl( aEmpty );
+    m_pToolBar->SetCommandHdl( Link<CommandEvent const *, void>() );
 
     m_pToolBar.clear();
 
@@ -1772,14 +1772,14 @@ bool ToolBarManager::MenuItemAllowed( sal_uInt16 ) const
     return pMenu;
 }
 
-IMPL_LINK( ToolBarManager, Command, CommandEvent*, pCmdEvt )
+IMPL_LINK_TYPED( ToolBarManager, Command, CommandEvent const *, pCmdEvt, void )
 {
     SolarMutexGuard g;
 
     if ( m_bDisposed )
-        return 1;
+        return;
     if ( pCmdEvt->GetCommand() != COMMAND_CONTEXTMENU )
-        return 0;
+        return;
 
     ::PopupMenu * pMenu = GetToolBarCustomMenu(m_pToolBar);
     if (pMenu)
@@ -1810,8 +1810,6 @@ IMPL_LINK( ToolBarManager, Command, CommandEvent*, pCmdEvt )
             pManagerMenu->SetDeactivateHdl( Link<>() );
         }
     }
-
-    return 0;
 }
 
 IMPL_LINK( ToolBarManager, MenuButton, ToolBox*, pToolBar )

include/vcl/toolbox.hxx

@@ -190,7 +190,7 @@ private:
     Link<ToolBox *, void> maActivateHdl;
     Link<ToolBox *, void> maDeactivateHdl;
     Link<ToolBox *, void> maSelectHdl;
-    Link<>              maCommandHandler;
+    Link<CommandEvent const *, void> maCommandHandler;
     Link<>              maStateChangedHandler;
     Link<>              maDataChangedHandler;
 
@@ -504,8 +504,7 @@ public:
     void                SetDeactivateHdl( const Link<ToolBox *, void>& rLink ) { maDeactivateHdl = rLink; }
     void                SetSelectHdl( const Link<ToolBox *, void>& rLink ) { maSelectHdl = rLink; }
     const Link<ToolBox *, void>& GetSelectHdl() const { return maSelectHdl; }
-    void                SetCommandHdl( const Link<>& aLink ) { maCommandHandler = aLink; }
-    const Link<>&       GetCommandHdl() const { return maCommandHandler; }
+    void                SetCommandHdl( const Link<CommandEvent const *, void>& aLink ) { maCommandHandler = aLink; }
     void                SetStateChangedHdl( const Link<>& aLink ) { maStateChangedHandler = aLink; }
     const Link<>&       GetStateChangedHdl() const { return maStateChangedHandler; }
     void                SetDataChangedHdl( const Link<>& aLink ) { maDataChangedHandler = aLink; }

vcl/source/window/toolbox.cxx

@@ -4357,7 +4357,7 @@ bool ToolBox::Notify( NotifyEvent& rNEvt )
 void ToolBox::Command( const CommandEvent& rCEvt )
 {
     if ( maCommandHandler.IsSet() )
-        maCommandHandler.Call( (void *)( &rCEvt ));
+        maCommandHandler.Call( &rCEvt );
 
     // depict StartDrag on MouseButton/Left/Alt
     if ( (rCEvt.GetCommand() == COMMAND_STARTDRAG) && rCEvt.IsMouseEvent() &&