Kaydet (Commit) 1fc34c75 authored tarafından Pierre-André Jacquod's avatar Pierre-André Jacquod

cppcheck scope reduction of var in soltools/...javadep.c

üst 2dc8787d
...@@ -198,15 +198,13 @@ read_utf8(const file_t *pfile) ...@@ -198,15 +198,13 @@ read_utf8(const file_t *pfile)
* Data is still in network byteorder * Data is still in network byteorder
*/ */
utf8_t a_utf8; utf8_t a_utf8;
size_t nread;
a_utf8.pdata = NULL; a_utf8.pdata = NULL;
a_utf8.nlen = read_uint16(pfile); a_utf8.nlen = read_uint16(pfile);
if (a_utf8.nlen > 0) { if (a_utf8.nlen > 0) {
a_utf8.pdata = xmalloc(a_utf8.nlen*sizeof(char)); a_utf8.pdata = xmalloc(a_utf8.nlen*sizeof(char));
nread = fread(a_utf8.pdata, a_utf8.nlen*sizeof(char), 1, pfile->pfs); size_t nread = fread(a_utf8.pdata, a_utf8.nlen*sizeof(char), 1, pfile->pfs);
if ( !nread ) { if ( !nread ) {
fclose(pfile->pfs); fclose(pfile->pfs);
err_quit("%s: truncated class file", pfile->pname); err_quit("%s: truncated class file", pfile->pname);
...@@ -265,8 +263,7 @@ add_to_dependencies(struct growable *pdep, ...@@ -265,8 +263,7 @@ add_to_dependencies(struct growable *pdep,
const char *pclass_file) const char *pclass_file)
{ {
/* create dependencies */ /* create dependencies */
int i; size_t nlen_pdepstr;
size_t nlen_filt, nlen_str, nlen_pdepstr;
char *pstr, *ptrunc; char *pstr, *ptrunc;
char path[PATH_MAX+1]; char path[PATH_MAX+1];
char cnp_class_file[PATH_MAX+1]; char cnp_class_file[PATH_MAX+1];
...@@ -282,9 +279,10 @@ add_to_dependencies(struct growable *pdep, ...@@ -282,9 +279,10 @@ add_to_dependencies(struct growable *pdep,
append_to_growable(pdep, strdup(pstr)); append_to_growable(pdep, strdup(pstr));
} }
} else { } else {
nlen_str = strlen(pstr); size_t nlen_str = strlen(pstr);
int i;
for ( i = 0; i < pfilt->ncur; i++ ) { for ( i = 0; i < pfilt->ncur; i++ ) {
nlen_filt = strlen(pfilt->parray[i]); size_t nlen_filt = strlen(pfilt->parray[i]);
if ( nlen_filt + 1 + nlen_str > PATH_MAX ) if ( nlen_filt + 1 + nlen_str > PATH_MAX )
err_quit("path to long"); err_quit("path to long");
memcpy(path, pfilt->parray[i], nlen_filt); memcpy(path, pfilt->parray[i], nlen_filt);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment