Kaydet (Commit) 229e85ac authored tarafından Stephan Bergmann's avatar Stephan Bergmann

elated fdo#60338: #error on umask(3) calls in currently unused code

(as dnssd_clientstub.c is only used on Windows), should we ever want to use it.

Change-Id: I5d9082ae69c505e4d60bbe8e60fdeaaf963a4614
üst d0787149
...@@ -621,6 +621,7 @@ static DNSServiceErrorType deliver_request(ipc_msg_hdr *hdr, DNSServiceOp *sdr) ...@@ -621,6 +621,7 @@ static DNSServiceErrorType deliver_request(ipc_msg_hdr *hdr, DNSServiceOp *sdr)
caddr.sun_len = sizeof(struct sockaddr_un); caddr.sun_len = sizeof(struct sockaddr_un);
#endif #endif
strcpy(caddr.sun_path, data); strcpy(caddr.sun_path, data);
#error "the below umask(3) calls are bad in a MT program (cf. fdo#60338):"
mask = umask(0); mask = umask(0);
bindresult = bind(listenfd, (struct sockaddr *)&caddr, sizeof(caddr)); bindresult = bind(listenfd, (struct sockaddr *)&caddr, sizeof(caddr));
umask(mask); umask(mask);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment