Kaydet (Commit) 2438f18b authored tarafından Tor Lillqvist's avatar Tor Lillqvist

WaE: variable set but not used, in NDEBUG build

Seems that people prefer this to be CPPUNIT_ASSERT() instead of
assert().

My first thinking was that there is a slight difference in meaning;
that assert() checks that the code (or, in this case, data) in the
test *itself* is as expected while CPPUNIT_ASSERT() checks that the
functionality *somewhere else* works as expected. But whatever.

Change-Id: I93f7f8cf2b3aac9e8fc35baf2dcbad1a4003773f
üst b9996778
...@@ -768,14 +768,14 @@ void ScOpenCLTest::testSystematic() ...@@ -768,14 +768,14 @@ void ScOpenCLTest::testSystematic()
} }
} }
assert(nAVertBegin != 0); CPPUNIT_ASSERT(nAVertBegin != 0);
assert(nBVertBegin != 0); CPPUNIT_ASSERT(nBVertBegin != 0);
assert(nAVertEnd > nAVertBegin + 100); CPPUNIT_ASSERT(nAVertEnd > nAVertBegin + 100);
assert(nBVertEnd > nBVertBegin + 100); CPPUNIT_ASSERT(nBVertEnd > nBVertBegin + 100);
assert((nAVertEnd-nAVertBegin) == (nBVertEnd-nBVertBegin)); CPPUNIT_ASSERT((nAVertEnd-nAVertBegin) == (nBVertEnd-nBVertBegin));
assert(nAHorEnd > 10); CPPUNIT_ASSERT(nAHorEnd > 10);
assert(nBHorEnd > 10); CPPUNIT_ASSERT(nBHorEnd > 10);
assert(nAHorEnd == nBHorEnd); CPPUNIT_ASSERT(nAHorEnd == nBHorEnd);
for (SCROW i = nAVertBegin; i < nAVertEnd; ++i) for (SCROW i = nAVertBegin; i < nAVertEnd; ++i)
{ {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment