loplugin:casttovoid: sfx2

Change-Id: If08aeb785b6ccffe477ddacc314f2182f6746648

sfx2/source/appl/shutdownicon.cxx

@@ -783,8 +783,8 @@ void ShutdownIcon::SetAutostart( bool bActivate )
         if ((0 != symlink(aDesktopFileUnx.getStr(), aShortcutUnx.getStr())) && (errno == EEXIST))
         {
             unlink(aShortcutUnx.getStr());
-            int ret = symlink(aDesktopFileUnx.getStr(), aShortcutUnx.getStr());
-            (void)ret; //deliberately ignore return value, it's non-critical if it fails
+            (void) symlink(aDesktopFileUnx.getStr(), aShortcutUnx.getStr());
+                //deliberately ignore return value, it's non-critical if it fails
         }
 
         ShutdownIcon *pIcon = ShutdownIcon::createInstance();

sfx2/source/control/statcach.cxx

@@ -391,8 +391,6 @@ void SfxStateCache::SetState_Impl
     bool bMaybeDirty
 )
 {
-    (void)bMaybeDirty; //unused
-
     // If a hard update occurs between enter- and leave-registrations is a
     // can also intermediate Cached exist without controller.
     if ( !pController && !pInternalController )

sfx2/source/control/thumbnailviewacc.cxx

@@ -483,7 +483,7 @@ uno::Reference< accessibility::XAccessible > SAL_CALL ThumbnailViewAcc::getSelec
     return xRet;
 }
 
-void SAL_CALL ThumbnailViewAcc::deselectAccessibleChild( sal_Int32 nChildIndex )
+void SAL_CALL ThumbnailViewAcc::deselectAccessibleChild( sal_Int32 )
 {
     ThrowIfDisposed();
     const SolarMutexGuard aSolarGuard;
@@ -491,7 +491,6 @@ void SAL_CALL ThumbnailViewAcc::deselectAccessibleChild( sal_Int32 nChildIndex )
     // the specified child is currently selected.
 //FIXME TODO    if (isAccessibleChildSelected(nChildIndex))
 //FIXME TODO        ;
-    (void) nChildIndex;
 }
 
 sal_Int64 SAL_CALL ThumbnailViewAcc::getSomething( const uno::Sequence< sal_Int8 >& rId )

sfx2/source/doc/Metadatable.cxx

@@ -1209,7 +1209,6 @@ XmlIdRegistryClipboard::RegisterCopyClipboard(Metadatable & i_rCopy,
         const bool success( m_pImpl->TryInsertMetadatable(i_rCopy,
                 i_rReference.First, i_rReference.Second) );
         OSL_ENSURE(success, "RegisterCopyClipboard: TryInsert failed?");
-        (void) success;
     }
     const std::shared_ptr<MetadatableClipboard> xLink(
         CreateClipboard( isContentFile(i_rReference.First)) );

sfx2/source/doc/docundomanager.cxx

@@ -414,9 +414,8 @@ namespace sfx2
     }
 
 
-    void SAL_CALL DocumentUndoManager::setParent( const Reference< XInterface >& i_parent )
+    void SAL_CALL DocumentUndoManager::setParent( const Reference< XInterface >& )
     {
-        (void)i_parent;
         throw NoSupportException( OUString(), m_pImpl->getThis() );
     }
 

sfx2/source/doc/objstor.cxx

@@ -2507,7 +2507,6 @@ bool SfxObjectShell::DoSave_Impl( const SfxItemSet* pArgs )
         bOpen = DoSaveCompleted( pMediumTmp );
 
         DBG_ASSERT(bOpen,"Error handling for DoSaveCompleted not implemented");
-        (void)bOpen;
     }
     else
     {
@@ -2801,7 +2800,6 @@ bool SfxObjectShell::PreDoSaveAs_Impl(const OUString& rFileName, const OUString&
                 bool bRet( false );
                 bRet = DoSaveCompleted( pMedium );
                 DBG_ASSERT( bRet, "Error in DoSaveCompleted, can't be handled!");
-                (void)bRet;
             }
 
             // TODO/LATER: disconnect the new file from the storage for the case when pure saving is done

sfx2/source/sidebar/Deck.cxx

@@ -141,9 +141,8 @@ void Deck::Paint(vcl::RenderContext& rRenderContext, const tools::Rectangle& /*r
                            Theme::GetPaint(Theme::Paint_VerticalBorder));
 }
 
-void Deck::DataChanged (const DataChangedEvent& rEvent)
+void Deck::DataChanged (const DataChangedEvent&)
 {
-    (void)rEvent;
     RequestLayout();
 }
 

sfx2/source/sidebar/Panel.cxx

@@ -152,9 +152,8 @@ void Panel::Resize()
     }
 }
 
-void Panel::DataChanged (const DataChangedEvent& rEvent)
+void Panel::DataChanged (const DataChangedEvent&)
 {
-    (void)rEvent;
     Invalidate();
 }
 

sfx2/source/sidebar/SidebarPanelBase.cxx

@@ -107,10 +107,8 @@ void SAL_CALL SidebarPanelBase::notifyContextChangeEvent (
 }
 
 void SAL_CALL SidebarPanelBase::disposing (
-    const css::lang::EventObject& rEvent)
+    const css::lang::EventObject&)
 {
-    (void)rEvent;
-
     mxFrame = nullptr;
     mpControl = nullptr;
 }
@@ -136,10 +134,8 @@ Reference<XInterface> SAL_CALL SidebarPanelBase::getRealInterface()
 }
 
 Reference<accessibility::XAccessible> SAL_CALL SidebarPanelBase::createAccessible (
-    const Reference<accessibility::XAccessible>& rxParentAccessible)
+    const Reference<accessibility::XAccessible>&)
 {
-    (void)rxParentAccessible;
-
     // Not yet implemented.
     return nullptr;
 }

sfx2/source/sidebar/TitleBar.cxx

@@ -166,7 +166,6 @@ void TitleBar::PaintFocus(vcl::RenderContext& rRenderContext, const tools::Recta
 
 IMPL_LINK(TitleBar, SelectionHandler, ToolBox*, pToolBox, void)
 {
-    (void)pToolBox;
     OSL_ASSERT(maToolBox.get()==pToolBox);
     const sal_uInt16 nItemId (maToolBox->GetHighlightItemId());