sc: fix loplugin:stringconstant warnings

Change-Id: I6f9e77ed380baba0a46374292fb2a65d41e15e71

sc/source/core/tool/appoptio.cxx

@@ -313,13 +313,13 @@ Sequence<OUString> ScAppCfg::GetCompatPropertyNames()
 }
 
 ScAppCfg::ScAppCfg() :
-    aLayoutItem( OUString( CFGPATH_LAYOUT ) ),
-    aInputItem( OUString( CFGPATH_INPUT ) ),
-    aRevisionItem( OUString( CFGPATH_REVISION ) ),
-    aContentItem( OUString( CFGPATH_CONTENT ) ),
-    aSortListItem( OUString( CFGPATH_SORTLIST ) ),
-    aMiscItem( OUString( CFGPATH_MISC ) ),
-    aCompatItem( OUString(CFGPATH_COMPAT ) )
+    aLayoutItem( CFGPATH_LAYOUT ),
+    aInputItem( CFGPATH_INPUT ),
+    aRevisionItem( CFGPATH_REVISION ),
+    aContentItem( CFGPATH_CONTENT ),
+    aSortListItem( CFGPATH_SORTLIST ),
+    aMiscItem( CFGPATH_MISC ),
+    aCompatItem( CFGPATH_COMPAT )
 {
     sal_Int32 nIntVal = 0;
 

sc/source/core/tool/docoptio.cxx

@@ -216,8 +216,8 @@ Sequence<OUString> ScDocCfg::GetLayoutPropertyNames()
 }
 
 ScDocCfg::ScDocCfg() :
-    aCalcItem( OUString( CFGPATH_CALC ) ),
-    aLayoutItem(OUString(CFGPATH_DOCLAYOUT))
+    aCalcItem( CFGPATH_CALC ),
+    aLayoutItem(CFGPATH_DOCLAYOUT)
 {
     sal_Int32 nIntVal = 0;
 

sc/source/core/tool/unitconv.cxx

@@ -60,7 +60,7 @@ ScUnitConverter::ScUnitConverter()
     // read from configuration - "convert.ini" is no longer used
     //TODO: config item as member to allow change of values
 
-    ScLinkConfigItem aConfigItem( OUString( CFGPATH_UNIT ) );
+    ScLinkConfigItem aConfigItem( CFGPATH_UNIT );
 
     // empty node name -> use the config item's path itself
     OUString aEmptyString;

sc/source/core/tool/viewopti.cxx

@@ -311,9 +311,9 @@ Sequence<OUString> ScViewCfg::GetGridPropertyNames()
 }
 
 ScViewCfg::ScViewCfg() :
-    aLayoutItem( OUString( CFGPATH_LAYOUT ) ),
-    aDisplayItem( OUString( CFGPATH_DISPLAY ) ),
-    aGridItem( OUString( CFGPATH_GRID ) )
+    aLayoutItem( CFGPATH_LAYOUT ),
+    aDisplayItem( CFGPATH_DISPLAY ),
+    aGridItem( CFGPATH_GRID )
 {
     sal_Int32 nIntVal = 0;
 

sc/source/ui/dbgui/csvruler.cxx

@@ -40,7 +40,7 @@ static void load_FixedWidthList(ScCsvSplits &rSplits)
     Sequence<Any>aValues;
     const Any *pProperties;
     Sequence<OUString> aNames { FIXED_WIDTH_LIST };
-    ScLinkConfigItem aItem( OUString( SEP_PATH ) );
+    ScLinkConfigItem aItem( SEP_PATH );
 
     aValues = aItem.GetProperties( aNames );
     pProperties = aValues.getConstArray();
@@ -73,7 +73,7 @@ static void save_FixedWidthList(const ScCsvSplits& rSplits)
     Sequence<Any> aValues;
     Any *pProperties;
     Sequence<OUString> aNames { FIXED_WIDTH_LIST };
-    ScLinkConfigItem aItem( OUString( SEP_PATH ) );
+    ScLinkConfigItem aItem( SEP_PATH );
 
     aValues = aItem.GetProperties( aNames );
     pProperties = aValues.getArray();