loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)

Change-Id: I8aedb690380d407dcbc290a44d21afa6604b8f95

xmlscript/source/xmldlg_imexp/xmldlg_export.cxx

@@ -1026,13 +1026,13 @@ void ElementDescriptor::readImageScaleModeAttr( OUString const & rPropName, OUSt
             switch(nImageScaleMode)
             {
                 case ::awt::ImageScaleMode::NONE:
-                    addAttribute( rAttrName, OUString( "none") );
+                    addAttribute( rAttrName, "none" );
                     break;
                 case ::awt::ImageScaleMode::ISOTROPIC:
-                    addAttribute( rAttrName, OUString( "isotropic") );
+                    addAttribute( rAttrName, "isotropic" );
                     break;
                 case ::awt::ImageScaleMode::ANISOTROPIC:
-                    addAttribute( rAttrName, OUString( "anisotropic" ) );
+                    addAttribute( rAttrName, "anisotropic" );
                     break;
                 default:
                     OSL_ENSURE( false, "### illegal image scale mode value.");

xmlscript/source/xmldlg_imexp/xmldlg_impmodels.cxx

@@ -208,7 +208,7 @@ void Page::endElement()
     }
 
     ctx.importDefaults( 0, 0, _xAttributes ); // inherited from BulletinBoardElement
-    ctx.importStringProperty( OUString( "Title" ), OUString( "title" ), _xAttributes );
+    ctx.importStringProperty( "Title", "title", _xAttributes );
     ctx.importEvents( _events );
     // avoid ring-reference:
     // vector< event elements > holding event elements holding this (via _pParent)

xmlscript/source/xmldlg_imexp/xmldlg_import.cxx

@@ -1564,23 +1564,23 @@ void ImportContext::importEvents(
 void ImportContext::importScollableSettings(
     Reference< xml::input::XAttributes > const & _xAttributes )
 {
-    importLongProperty( OUString( "ScrollHeight" ),
-                        OUString( "scrollheight" ),
+    importLongProperty( "ScrollHeight",
+                        "scrollheight",
                         _xAttributes );
-    importLongProperty( OUString( "ScrollWidth" ),
-                        OUString( "scrollwidth" ),
+    importLongProperty( "ScrollWidth",
+                        "scrollwidth",
                         _xAttributes );
-    importLongProperty( OUString( "ScrollTop" ),
-                        OUString( "scrolltop" ),
+    importLongProperty( "ScrollTop",
+                        "scrolltop",
                         _xAttributes );
-    importLongProperty( OUString( "ScrollLeft" ),
-                        OUString( "scrollleft" ),
+    importLongProperty( "ScrollLeft",
+                        "scrollleft",
                         _xAttributes );
-    importBooleanProperty( OUString( "HScroll" ),
-                           OUString( "hscroll" ),
+    importBooleanProperty( "HScroll",
+                           "hscroll",
                            _xAttributes );
-    importBooleanProperty( OUString( "VScroll" ),
-                           OUString( "vscroll" ),
+    importBooleanProperty( "VScroll",
+                           "vscroll",
                            _xAttributes );
 }
 

xmlscript/source/xmllib_imexp/xmllib_export.cxx

@@ -130,7 +130,7 @@ SAL_CALL exportLibrary(
             Reference< xml::sax::XAttributeList > xElementAttribs;
             xElementAttribs = static_cast< xml::sax::XAttributeList* >( pElement );
 
-            pElement->addAttribute( OUString( XMLNS_LIBRARY_PREFIX ":name" ),
+            pElement->addAttribute( XMLNS_LIBRARY_PREFIX ":name",
                                         pElementNames[i] );
 
             pLibElement->addSubElement( pElement );