gdb-core-bt: don't talk about core files without a reason.

When exit code is <128, then the test probably just failed, it did not
get a SIGSEGV or similar signal, so it's expected that no core file is
created.

Change-Id: Ie9e3599bd6738c04afacb95000d09f9dd2a5c426

solenv/bin/gdb-core-bt.sh

@@ -30,6 +30,7 @@
 
 EXECUTABLE=${1}
 COREDIR=${2}
+EXITCODE=${3}
 
 if test -n "$(which gdb)"
 then
@@ -45,7 +46,7 @@ then
         rm "$GDBCOMMANDFILE"
         echo
         exit 0
-    else
+    elif [ $EXITCODE -ge 128 ]; then
         echo
         echo "No core file identified in directory ${COREDIR}"
         echo "To show backtraces for crashes during test execution,"

solenv/gbuild/CppunitTest.mk

@@ -97,9 +97,9 @@ $(call gb_CppunitTest_get_target,%) :| $(gb_CppunitTest_CPPTESTDEPS)
 		$(call gb_CppunitTest__make_args) \
 		$(if $(gb_CppunitTest__interactive),, \
 			> $@.log 2>&1 \
-			|| (cat $@.log && $(UNIT_FAILED_MSG) \
+			|| (RET=$$? && cat $@.log && $(UNIT_FAILED_MSG) \
 				$(if $(value gb_CppunitTest_postprocess), \
-					&& $(call gb_CppunitTest_postprocess,$(gb_CppunitTest_CPPTESTCOMMAND),$@.core)) \
+					&& $(call gb_CppunitTest_postprocess,$(gb_CppunitTest_CPPTESTCOMMAND),$@.core,$$RET)) \
 				&& false))))
 
 define gb_CppunitTest_CppunitTest

solenv/gbuild/platform/solaris.mk

@@ -342,7 +342,7 @@ $(call gb_LinkTarget_get_target,$(2)) : RPATH :=
 endef
 
 define gb_CppunitTest_postprocess
-$(SRCDIR)/solenv/bin/gdb-core-bt.sh $(1) $(2)
+$(SRCDIR)/solenv/bin/gdb-core-bt.sh $(1) $(2) $(3)
 endef
 
 # JunitTest class

solenv/gbuild/platform/unxgcc.mk

@@ -339,7 +339,7 @@ $(call gb_LinkTarget_get_target,$(2)) : RPATH :=
 endef
 
 define gb_CppunitTest_postprocess
-$(SRCDIR)/solenv/bin/gdb-core-bt.sh $(1) $(2)
+$(SRCDIR)/solenv/bin/gdb-core-bt.sh $(1) $(2) $(3)
 endef
 
 # JunitTest class