Kaydet (Commit) 2ce5d7d2 authored tarafından Timothy Markle's avatar Timothy Markle Kaydeden (comit) Caolán McNamara

fdo#66822 - refactor HTML export of image to bullet list

Replaced src attribute with style attribute in <ul>.
Removed invalid width, height, and align attributes.
Removed two unused variables rSize and pVert.

Change-Id: I40390bd02c7fb11a445da44d33492a59c8e6372c
üst c2056dc4
...@@ -974,8 +974,7 @@ void OutHTML_SwFmt( Writer& rWrt, const SwFmt& rFmt, ...@@ -974,8 +974,7 @@ void OutHTML_SwFmt( Writer& rWrt, const SwFmt& rFmt,
OSL_ENSURE( aNumInfo.GetNumRule(), "Wo ist die Numerierung geblieben???" ); OSL_ENSURE( aNumInfo.GetNumRule(), "Wo ist die Numerierung geblieben???" );
OSL_ENSURE( nBulletGrfLvl < MAXLEVEL, "So viele Ebenen gibt's nicht" ); OSL_ENSURE( nBulletGrfLvl < MAXLEVEL, "So viele Ebenen gibt's nicht" );
const SwNumFmt& rNumFmt = aNumInfo.GetNumRule()->Get(nBulletGrfLvl); const SwNumFmt& rNumFmt = aNumInfo.GetNumRule()->Get(nBulletGrfLvl);
OutHTML_BulletImage( rWrt, OOO_STRING_SVTOOLS_HTML_image, rNumFmt.GetBrush(), OutHTML_BulletImage( rWrt, OOO_STRING_SVTOOLS_HTML_image, rNumFmt.GetBrush() );
rNumFmt.GetGraphicSize(), rNumFmt.GetGraphicOrientation() );
} }
rHWrt.GetNumInfo() = aNumInfo; rHWrt.GetNumInfo() = aNumInfo;
......
...@@ -1188,9 +1188,7 @@ Writer& OutHTML_Image( Writer& rWrt, const SwFrmFmt &rFrmFmt, ...@@ -1188,9 +1188,7 @@ Writer& OutHTML_Image( Writer& rWrt, const SwFrmFmt &rFrmFmt,
Writer& OutHTML_BulletImage( Writer& rWrt, Writer& OutHTML_BulletImage( Writer& rWrt,
const sal_Char *pTag, const sal_Char *pTag,
const SvxBrushItem* pBrush, const SvxBrushItem* pBrush )
const Size &rSize,
const SwFmtVertOrient* pVertOrient )
{ {
SwHTMLWriter & rHTMLWrt = (SwHTMLWriter&)rWrt; SwHTMLWriter & rHTMLWrt = (SwHTMLWriter&)rWrt;
...@@ -1213,59 +1211,12 @@ Writer& OutHTML_BulletImage( Writer& rWrt, ...@@ -1213,59 +1211,12 @@ Writer& OutHTML_BulletImage( Writer& rWrt,
sOut.append('<').append(pTag); sOut.append('<').append(pTag);
sOut.append(' '); sOut.append(' ');
sOut.append(OOO_STRING_SVTOOLS_HTML_O_src).append("=\""). sOut.append(OOO_STRING_SVTOOLS_HTML_O_style).append("=\"").
append("list-style-image: ").append("url(").
append(OOO_STRING_SVTOOLS_HTML_O_data).append(":"); append(OOO_STRING_SVTOOLS_HTML_O_data).append(":");
rWrt.Strm().WriteCharPtr( sOut.makeStringAndClear().getStr() ); rWrt.Strm().WriteCharPtr( sOut.makeStringAndClear().getStr() );
HTMLOutFuncs::Out_String( rWrt.Strm(), aGraphicInBase64, rHTMLWrt.eDestEnc, &rHTMLWrt.aNonConvertableCharacters ); HTMLOutFuncs::Out_String( rWrt.Strm(), aGraphicInBase64, rHTMLWrt.eDestEnc, &rHTMLWrt.aNonConvertableCharacters );
sOut.append('\"'); sOut.append(");").append('\"');
// Groesse des Objekts Twips ohne Raender
Size aPixelSz( 0, 0 );
if( (rSize.Width() || rSize.Height()) && Application::GetDefaultDevice() )
{
aPixelSz =
Application::GetDefaultDevice()->LogicToPixel( rSize,
MapMode(MAP_TWIP) );
if( !aPixelSz.Width() && rSize.Width() )
aPixelSz.Width() = 1;
if( !aPixelSz.Height() && rSize.Height() )
aPixelSz.Height() = 1;
}
if( aPixelSz.Width() )
{
sOut.append(' ').append(OOO_STRING_SVTOOLS_HTML_O_width).
append("=\"").append(static_cast<sal_Int32>(aPixelSz.Width())).append("\"");
}
if( aPixelSz.Height() )
{
sOut.append(' ').append(OOO_STRING_SVTOOLS_HTML_O_height).
append("=\"").append(static_cast<sal_Int32>(aPixelSz.Height())).append("\"");
}
if( pVertOrient )
{
const sal_Char *pStr = 0;
switch( pVertOrient->GetVertOrient() )
{
case text::VertOrientation::LINE_TOP: pStr = OOO_STRING_SVTOOLS_HTML_VA_top; break;
case text::VertOrientation::CHAR_TOP:
case text::VertOrientation::BOTTOM: pStr = OOO_STRING_SVTOOLS_HTML_VA_texttop; break; // geht nicht
case text::VertOrientation::LINE_CENTER:
case text::VertOrientation::CHAR_CENTER: pStr = OOO_STRING_SVTOOLS_HTML_VA_absmiddle; break; // geht nicht
case text::VertOrientation::CENTER: pStr = OOO_STRING_SVTOOLS_HTML_VA_middle; break;
case text::VertOrientation::LINE_BOTTOM:
case text::VertOrientation::CHAR_BOTTOM: pStr = OOO_STRING_SVTOOLS_HTML_VA_absbottom; break; // geht nicht
case text::VertOrientation::TOP: pStr = OOO_STRING_SVTOOLS_HTML_VA_bottom; break;
case text::VertOrientation::NONE: break;
}
if( pStr )
{
sOut.append(' ').append(OOO_STRING_SVTOOLS_HTML_O_align).
append("=\"").append(pStr).append("\"");
}
}
if (pTag) if (pTag)
sOut.append('>'); sOut.append('>');
......
...@@ -827,9 +827,7 @@ Writer& OutHTML_NumBulListStart( SwHTMLWriter& rWrt, ...@@ -827,9 +827,7 @@ Writer& OutHTML_NumBulListStart( SwHTMLWriter& rWrt,
rWrt.Strm().WriteCharPtr( sOut.makeStringAndClear().getStr() ); rWrt.Strm().WriteCharPtr( sOut.makeStringAndClear().getStr() );
OutHTML_BulletImage( rWrt, OutHTML_BulletImage( rWrt,
0, 0,
rNumFmt.GetBrush(), rNumFmt.GetBrush() );
rNumFmt.GetGraphicSize(),
rNumFmt.GetGraphicOrientation() );
} }
else else
{ {
......
...@@ -630,9 +630,7 @@ Writer& OutHTML_Image( Writer&, const SwFrmFmt& rFmt, ...@@ -630,9 +630,7 @@ Writer& OutHTML_Image( Writer&, const SwFrmFmt& rFmt,
const ImageMap *pGenImgMap = 0 ); const ImageMap *pGenImgMap = 0 );
Writer& OutHTML_BulletImage( Writer& rWrt, const sal_Char *pTag, Writer& OutHTML_BulletImage( Writer& rWrt, const sal_Char *pTag,
const SvxBrushItem* pBrush, const SvxBrushItem* pBrush );
const Size &rSize,
const SwFmtVertOrient* pVertOrient );
Writer& OutHTML_SwFmtFld( Writer& rWrt, const SfxPoolItem& rHt ); Writer& OutHTML_SwFmtFld( Writer& rWrt, const SfxPoolItem& rHt );
Writer& OutHTML_SwFmtFtn( Writer& rWrt, const SfxPoolItem& rHt ); Writer& OutHTML_SwFmtFtn( Writer& rWrt, const SfxPoolItem& rHt );
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment