loplugin:unnecessaryparen (clang-cl)

Change-Id: I5452235287fd5986de25ee542edd57bf1abded52
Reviewed-on: https://gerrit.libreoffice.org/45338Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

cui/source/options/optpath.cxx

@@ -496,7 +496,7 @@ void SvxPathTabPage::ChangeCurrentEntry( const OUString& _rFolder )
 // Unix is case sensitive
         ( sNewPathStr != sWritable );
 #else
-        ( !sNewPathStr.equalsIgnoreAsciiCase( sWritable ) );
+        !sNewPathStr.equalsIgnoreAsciiCase( sWritable );
 #endif
 
     if ( bChanged )

embedserv/source/embed/intercept.cxx

@@ -233,7 +233,7 @@ void Interceptor::generateFeatureStateEvent()
             {
                 aStateEvent.FeatureURL.Complete = m_aInterceptedURL[5];
                 aStateEvent.FeatureDescriptor = "SaveCopyTo";
-                aStateEvent.State <<= (OUString("($3)"));
+                aStateEvent.State <<= OUString("($3)");
             }
             else
             {
@@ -345,7 +345,7 @@ Interceptor::addStatusListener(
         aStateEvent.FeatureDescriptor = "SaveCopyTo";
         aStateEvent.IsEnabled = true;
         aStateEvent.Requery = false;
-        aStateEvent.State <<= (OUString("($3)"));
+        aStateEvent.State <<= OUString("($3)");
         Control->statusChanged(aStateEvent);
 
         {

extensions/source/activex/so_activex.cxx

@@ -737,7 +737,7 @@ STDAPI DllRegisterServer()
 
     HMODULE aCurModule = GetModuleHandleW( bX64 ? X64_LIB_NAME : X32_LIB_NAME );
     DWORD nLibNameLen = sal::static_int_cast<DWORD>(
-            wcslen((bX64) ? X64_LIB_NAME : X32_LIB_NAME));
+            wcslen(bX64 ? X64_LIB_NAME : X32_LIB_NAME));
 
     if( aCurModule )
     {

sal/osl/w32/socket.cxx

@@ -1234,7 +1234,7 @@ sal_Bool SAL_CALL osl_isReceiveReady (
                    &fds,                        /* check read operations */
                    nullptr,                     /* check write ops */
                    nullptr,                     /* ckeck for OOB */
-                   (pTimeout) ? &tv : nullptr)==1); /* use timeout? */
+                   pTimeout ? &tv : nullptr)==1); /* use timeout? */
 }
 
 /*****************************************************************************/
@@ -1263,7 +1263,7 @@ sal_Bool SAL_CALL osl_isSendReady (
                    nullptr,                     /* check read operations */
                    &fds,                        /* check write ops */
                    nullptr,                     /* ckeck for OOB */
-                   (pTimeout) ? &tv : nullptr)==1); /* use timeout? */
+                   pTimeout ? &tv : nullptr)==1); /* use timeout? */
 }
 
 sal_Bool SAL_CALL osl_isExceptionPending (
@@ -1289,7 +1289,7 @@ sal_Bool SAL_CALL osl_isExceptionPending (
                    nullptr,                     /* check read operations */
                    nullptr,                     /* check write ops */
                    &fds,                        /* ckeck for OOB */
-                   (pTimeout) ? &tv : nullptr)==1); /* use timeout? */
+                   pTimeout ? &tv : nullptr)==1); /* use timeout? */
 }
 
 sal_Bool SAL_CALL osl_shutdownSocket (

shell/source/win32/simplemail/smplmailclient.cxx

@@ -102,7 +102,7 @@ namespace /* private */
 
         if (senddocUrl.isEmpty())
         {
-            senddocUrl = ( "$BRAND_BASE_DIR/" LIBO_LIBEXEC_FOLDER "/senddoc.exe");
+            senddocUrl = "$BRAND_BASE_DIR/" LIBO_LIBEXEC_FOLDER "/senddoc.exe";
             rtl::Bootstrap::expandMacros(senddocUrl); //TODO: detect failure
         }
         return senddocUrl;

tools/source/stream/strmwnt.cxx

@@ -293,9 +293,9 @@ void SvFileStream::Open( const OUString& rFilename, StreamMode nMode )
     if( nMode & StreamMode::SHARE_DENYALL)
         nShareMode = 0;
 
-    if( (nMode & StreamMode::READ) )
+    if( nMode & StreamMode::READ )
         nAccessMode |= GENERIC_READ;
-    if( (nMode & StreamMode::WRITE) )
+    if( nMode & StreamMode::WRITE )
         nAccessMode |= GENERIC_WRITE;
 
     if( nAccessMode == GENERIC_READ )       // ReadOnly ?

vcl/win/gdi/salnativewidgets-luna.cxx

@@ -1075,7 +1075,7 @@ bool ImplDrawNativeControl( HDC hDC, HTHEME hTheme, RECT rc,
             }
             else if( nPart == ControlPart::MenuItem )
             {
-                if( (nState & ControlState::ENABLED) )
+                if( nState & ControlState::ENABLED )
                     iState = (nState & ControlState::SELECTED) ? MPI_HOT : MPI_NORMAL;
                 else
                     iState = (nState & ControlState::SELECTED) ? MPI_DISABLEDHOT : MPI_DISABLED;
@@ -1083,7 +1083,7 @@ bool ImplDrawNativeControl( HDC hDC, HTHEME hTheme, RECT rc,
             }
             else if( nPart == ControlPart::MenuItemCheckMark || nPart == ControlPart::MenuItemRadioMark )
             {
-                if( (nState & ControlState::PRESSED) )
+                if( nState & ControlState::PRESSED )
                 {
                     RECT aBGRect = rc;
                     if( aValue.getType() == ControlType::MenuPopup )

vcl/win/gdi/salprn.cxx

@@ -973,7 +973,7 @@ static void ImplJobSetupToDevMode( WinSalInfoPrinter const * pPrinter, const Imp
             }
         }
     }
-    if( (nFlags & JobSetFlags::DUPLEXMODE) )
+    if( nFlags & JobSetFlags::DUPLEXMODE )
     {
         switch( pSetupData->GetDuplexMode() )
         {